Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: long SubMenu title display #22971

Closed
wants to merge 19 commits into from
Closed

fix: long SubMenu title display #22971

wants to merge 19 commits into from

Conversation

wwyx778
Copy link
Contributor

@wwyx778 wwyx778 commented Apr 7, 2020 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22609

💡 Background and solution

Fix Long Submenu Title Being Overlayed By Arrow Icon

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@yoyo837 yoyo837 requested a review from afc163 April 7, 2020 02:01
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 7, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04c3713:

Sandbox Source
antd reproduction template Configuration

xrkffgg
xrkffgg requested changes Apr 7, 2020
View reviewed changes
components/menu/style/index.less Outdated
@@ -396,7 +396,7 @@
height: @menu-item-height;
margin-top: @menu-item-vertical-margin;
margin-bottom: @menu-item-vertical-margin;
padding: 0 16px;
padding: 0 34px 0 16px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不建议在公共样式中修改，可单独处理这个。

顺便 rebase 下 master

@wwyx778 wwyx778 requested a review from zombieJ as a code owner April 8, 2020 03:35
@yoyo837
Copy link
Contributor

yoyo837 commented Apr 8, 2020

Commits should be clean.

@wwyx778
Copy link
Contributor Author

wwyx778 commented Apr 8, 2020

Commits should be clean.

我可以关掉这个PR重新来一次吗？

@yoyo837 yoyo837 closed this Apr 8, 2020
@yoyo837
Copy link
Contributor

yoyo837 commented Apr 8, 2020

先fetch最新rebase 到 你的分支，如果是后面同步最新的可能需要--force push

@wwyx778 wwyx778 deleted the fix-issue-22609 branch April 8, 2020 03:47
@wwyx778
Copy link
Contributor Author

wwyx778 commented Apr 8, 2020

先fetch最新rebase 到 你的分支，如果是后面同步最新的可能需要--force push

好的。谢谢。

@github-actions
Copy link
Contributor

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#4.9.0

  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度和叙述方式撰写，不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题，而非你的解决方式
    • 参考：https://ant.design/changelog-cn#4.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg requested changes

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long Submenu Title Being Overlayed By Arrow Icon
9 participants
@wwyx778 @ant-design-bot @yoyo837 @xrkffgg @zombieJ @afc163 @AshoneA @fjc0k @chenxsan