Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): optimize RangePicker's range area style #44206

Merged
merged 3 commits into from Aug 14, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Aug 14, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Before:

image

After:

image

📝 Changelog

Language Changelog
🇺🇸 English optimize RangePicker's range area style
🇨🇳 Chinese 优化 RangePicker 选择区域样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 956bc86

This pull request improves the style and code quality of the date picker component. It adjusts the border radius of the range picker cells to match the design spec, and simplifies the object assignment in generateRangePicker.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at 956bc86

  • Simplify the assignment of additionalOverrideProps in generateRangePicker.tsx by using a single object literal (link)
  • Update the border radius values of the inner cell style for the range picker component in index.ts to match the design spec and use borderRadiusSM instead of lineWidth (link, link)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 387.01 KB (+4 B 🔺)
./dist/antd-with-locales.min.js 446.1 KB (+5 B 🔺)

@afc163
Copy link
Member

afc163 commented Aug 14, 2023

图片

右边接缝处最好是方的。

@kiner-tang
Copy link
Member Author

图片 右边接缝处最好是方的。

👌🏻

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (72b449a) 100.00% compared to head (f899cb0) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #44206    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          663       659     -4     
  Lines        11699     11199   -500     
  Branches      3186      3033   -153     
==========================================
- Hits         11699     11199   -500     
Files Changed Coverage Δ
components/date-picker/style/index.ts 100.00% <ø> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang
Copy link
Member Author

图片 右边接缝处最好是方的。

image

@MadCcc MadCcc merged commit 41cb8be into master Aug 14, 2023
86 checks passed
@MadCcc MadCcc deleted the opt-range-picker-borderRadius branch August 14, 2023 12:59
afc163 pushed a commit to gouge666/ant-design that referenced this pull request Aug 16, 2023
…44206)

* feat: optimize range-picker's range area style

* feat: optimize range-picker's range area style

* feat: optimize range-picker's range area style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants