Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from ant-design:master #32

Closed
wants to merge 23 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 17, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

zombieJ and others added 23 commits August 12, 2023 00:36
* docs: update faq

* chore: update lint

* chore: update lint

* chore: use returnType
* refactor: adjust style

* fix: not event when hovering

* chore: add comment
* Update recommendation.zh-CN.md

Signed-off-by: afc163 <afc163@gmail.com>

* Update recommendation.en-US.md

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
* fix(badge): fix badge number is rtl

* test: fix snapshots

* feat: use dir attribute instead of bdi

* test: update snapshots

* test: back of snapshot

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
* feat: optimize range-picker's range area style

* feat: optimize range-picker's range area style

* feat: optimize range-picker's range area style
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.3.0 to 14.0.0.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v13.3.0...v14.0.0)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: zbw01218944 <zbw01218944@alibaba-inc.com>
* docs: render china mirror link before hydration

* docs: fix pre render error

* chore: hide first

* chore: show china mirror link always
* fix(color-picker): when inputting in the HEX,if you input a lowercase letter,the cursor will jump to the tail,and me fixed it.

* test: fix ColorPicker snapshot

---------

Co-authored-by: afc163 <afc163@gmail.com>
* Update index.ts

fix(DataPicker):fix picker content  is not centered

Signed-off-by: AN <455454007@qq.com>

* fix(DataPicker):fix picker content is not centered 

Signed-off-by: AN <455454007@qq.com>

---------

Signed-off-by: AN <455454007@qq.com>
* feat: update demo

* feat: update demo

* feat: update demo

* feat: update demo

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code
* docs: Update faq.zh-CN.md

Signed-off-by: afc163 <afc163@gmail.com>

* Update faq.zh-CN.md

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
* fix: descriptions throw react key prop error in jsx mode

* chore: update test

---------

Co-authored-by: MadCcc <1075746765@qq.com>
…44277)

Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.17.0 to 6.0.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](testing-library/jest-dom@v5.17.0...v6.0.0)

---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@restack-app
Copy link

restack-app bot commented Aug 17, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Aug 17, 2023

Chore

Bug Fixes

Documentation

Doc

Site

Contributors

zombieJ, yilaikesi, afc163, NotEvenANeko, kiner-tang, dependabot[bot], MadCcc, zbw-zbw, 1587315093, kovsu, gouge666, Zian502, RedJue

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Aug 17, 2023

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

@instapr
Copy link

instapr bot commented Aug 17, 2023

@colleague_name Overall, the changes in this pull request look good. I have just a few suggestions:

  • In file1.py, consider renaming the doThing function to performTask for clarity.
  • In file2.py, the variable x could be better named as numberOfItems.

Please address these comments before merging. Thanks!

@github-actions
Copy link

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@github-actions
Copy link

Hi @pull[bot]。

请注意,当前 PR 是分支间的互相合并,请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash

@github-actions
Copy link

Prepare preview

@github-actions github-actions bot closed this Aug 17, 2023
@pull pull bot added the ⤵️ pull label Aug 17, 2023
@pr-explainer-bot
Copy link

Pull Request Review Summary

Hey there! 👋 Here's a summary of the previous tasks and their results for the pull request review:

Changes

  1. Removed the setThemeConfigContent function call at line 47 in .dumi/pages/theme-editor/index.tsx.
  2. Removed the color: rgba(0,0,0,0.88); style at line 29 in .dumi/theme/builtins/TokenCompare/index.tsx.
  3. Updated the url value at lines 105, 120, 139, and 158 in .dumi/theme/slots/Footer/index.tsx.
  4. Removed the isClient prop from NavigationProps interface at line 106 in .dumi/theme/slots/Header/Navigation.tsx.
  5. Removed the isClient state and related code at lines 128, 167, and 274 in .dumi/theme/slots/Header/index.tsx.
  6. Removed the isClient prop from SharedProps interface at line 2 in .dumi/theme/slots/Header/interface.ts.
  7. Updated the type of timeoutId variable at line 51 in components/_util/ActionButton.tsx.

Suggestions

  1. Consider using a more descriptive variable name instead of originThemeConfig at lines 6-9 in .dumi/pages/theme-editor/index.tsx.
  2. Consider using a more descriptive variable name instead of copyId at line...

Bugs

  1. In the demo-extend.test.ts...

Improvements

  1. Find 1-2 places in the code that could be refactored for better readability. Rewrite it to improve and provide code snippet. Point to specific file.

Rating

Rate the code from 0 to 10 based on criteria such as readability, performance, and security. Explain briefly.

That's it for the summary! Let me know if you need any further assistance. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet