Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from ant-design:master #33

Closed
wants to merge 23 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 18, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

zombieJ and others added 23 commits August 12, 2023 00:36
* docs: update faq

* chore: update lint

* chore: update lint

* chore: use returnType
* refactor: adjust style

* fix: not event when hovering

* chore: add comment
* Update recommendation.zh-CN.md

Signed-off-by: afc163 <afc163@gmail.com>

* Update recommendation.en-US.md

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
* fix(badge): fix badge number is rtl

* test: fix snapshots

* feat: use dir attribute instead of bdi

* test: update snapshots

* test: back of snapshot

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
* feat: optimize range-picker's range area style

* feat: optimize range-picker's range area style

* feat: optimize range-picker's range area style
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.3.0 to 14.0.0.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v13.3.0...v14.0.0)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: zbw01218944 <zbw01218944@alibaba-inc.com>
* docs: render china mirror link before hydration

* docs: fix pre render error

* chore: hide first

* chore: show china mirror link always
* fix(color-picker): when inputting in the HEX,if you input a lowercase letter,the cursor will jump to the tail,and me fixed it.

* test: fix ColorPicker snapshot

---------

Co-authored-by: afc163 <afc163@gmail.com>
* Update index.ts

fix(DataPicker):fix picker content  is not centered

Signed-off-by: AN <455454007@qq.com>

* fix(DataPicker):fix picker content is not centered 

Signed-off-by: AN <455454007@qq.com>

---------

Signed-off-by: AN <455454007@qq.com>
* feat: update demo

* feat: update demo

* feat: update demo

* feat: update demo

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code
* docs: Update faq.zh-CN.md

Signed-off-by: afc163 <afc163@gmail.com>

* Update faq.zh-CN.md

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
* fix: descriptions throw react key prop error in jsx mode

* chore: update test

---------

Co-authored-by: MadCcc <1075746765@qq.com>
…44277)

Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.17.0 to 6.0.0.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](testing-library/jest-dom@v5.17.0...v6.0.0)

---
updated-dependencies:
- dependency-name: "@testing-library/jest-dom"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@restack-app
Copy link

restack-app bot commented Aug 18, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Aug 18, 2023

Chore

Bug Fixes

Documentation

Doc

Site

Contributors

zombieJ, yilaikesi, afc163, NotEvenANeko, kiner-tang, dependabot[bot], MadCcc, zbw-zbw, 1587315093, kovsu, gouge666, Zian502, RedJue

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Aug 18, 2023

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

@instapr
Copy link

instapr bot commented Aug 18, 2023

The PR looks good overall. I have left a few minor comments inline. Please address them before merging. Thanks!

Also, please remove the automated message at the bottom of the PR body. It is not necessary for this type of PR.

@github-actions
Copy link

Hi @pull[bot]。

请注意,当前 PR 是分支间的互相合并,请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash

@github-actions
Copy link

Prepare preview

@github-actions
Copy link

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@github-actions github-actions bot closed this Aug 18, 2023
@pull pull bot added the ⤵️ pull label Aug 18, 2023
@pr-explainer-bot
Copy link

Pull Request Review Markdown Doc

Hey there! 👋 Here's a summary of the previous tasks and their results, along with some additional information:

Changes

  1. Removed the setThemeConfigContent(originThemeConfig); line from the CustomTheme component in .dumi/pages/theme-editor/index.tsx. (Task 1)
  2. Changed the copyId variable declaration in .dumi/theme/builtins/IconSearch/Category.tsx to use the ReturnType<typeof setTimeout> type. (Task 1)
  3. Added color: rgba(0,0,0,0.88); to the useStyle hook in .dumi/theme/builtins/TokenCompare/index.tsx. (Task 1)
  4. Updated the url values in the Footer component in .dumi/theme/slots/Footer/index.tsx to use different URLs based on the isZhCN variable. (Task 1)
  5. Added color: ${colorText}; and a:before styles to the useStyle hook in .dumi/theme/slots/Header/Navigation.tsx. (Task 1)
  6. Removed the isClient state and related code from the Header component in .dumi/theme/slots/Header/index.tsx. (Task 1)
  7. Changed the type of timeoutId variable in components/_util/ActionButton.tsx to use ReturnType<typeof setTimeout>. (Task 1)
  8. Updated the snapshot in components/badge/__tests__/__snapshots__/demo-extend.test.ts.snap. (Task 1)

Suggestions

  1. In .dumi/pages/theme-editor/index.tsx, consider removing the style attribute with transition: none; from the <span> element with class 'ant-scroll-number-only'. (Task 2)
  2. In .dumi/theme/builtins/IconSearch/Category.tsx, consider removing the style attribute with transition: none; from the <span> element with class 'ant-scroll-number-only'. (Task 2)
  3. In .dumi/theme/builtins/TokenCompare/index.tsx, consider removing the style attribute with transition: none; from the <span> element with class 'ant-scroll-number-only'. (Task 2)
  4. In .dumi/theme/builtins/TokenCompare/index.tsx, consider removing the style attribute with transition: none; from the <span> element with class 'ant-scroll-number-only'. (Task 2)
  5. In .dumi/theme/builtins/TokenCompare/index.tsx, consider removing the style attribute with transition: none; from the <span> element with class 'ant-scroll-number-only'. (Task 2)
  6. In .dumi/theme/builtins/TokenCompare/index.tsx, consider removing the style attribute with transition: none; from the <span> element with class 'ant-scroll-number-only'. (Task 2)

Bugs

  1. Line 24-26: Changed the structure of the HTML elements. Added a <bdi> element wrapping the <span> element with class 'ant-scroll-number-only'. (Task 3)
  2. Line 136-138: Changed the structure of the HTML elements. Added a <bdi> element wrapping the <span> element with class 'ant-scroll-number-only'. (Task 3)
  3. Line 655-657: Changed the structure of the HTML elements. Added a <bdi> element wrapping the <span> element with class 'ant-scroll-number-only'. (Task 3)
  4. Line 695-697: Changed the structure of the HTML elements. Added a <bdi> element wrapping the <span> element with class 'ant-scroll-number-only'. (Task 3)
  5. Line 735-737: Changed the structure of the HTML elements. Added a <bdi> element wrapping the <span> element with class 'ant-scroll-number-only'. (Task 3)
  6. Line 775-777: Changed the structure of the HTML elements. Added a <bdi> element wrapping the <span> element with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet