New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add React.forwardRef to fix warning #45390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
需要测试用例 |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45390 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 694 694
Lines 11676 11678 +2
Branches 3118 3120 +2
=========================================
+ Hits 11676 11678 +2
☔ View full report in Codecov by Sentry. |
done~ |
MadCcc
reviewed
Oct 18, 2023
Co-authored-by: MadCcc <1075746765@qq.com> Signed-off-by: lijianan <574980606@qq.com>
MadCcc
reviewed
Oct 19, 2023
Co-authored-by: MadCcc <1075746765@qq.com> Signed-off-by: lijianan <574980606@qq.com>
afc163
approved these changes
Oct 20, 2023
This was referenced Oct 21, 2023
This was referenced Oct 24, 2023
This was referenced Nov 1, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 2e058ae
Refactored
FloatButton
component and related components to improve ref forwarding and typing. UsedcomposeRef
andReact.forwardRef
to merge refs and pass them toFloatButton
. Createdinterface.ts
to store common types forFloatButton
and its usage inBackTop
andFloatButtonGroup
.🔍 Walkthrough
🤖 Generated by Copilot at 2e058ae
FloatButton
component to accept a genericButtonRef
type instead of specific HTML element types (link,link,link,link,link,link)composeRef
to merge external and internal refs ofFloatButton
component inBackTop
andFloatButtonGroup
components (link,link,link,link,link)BackTop
component withReact.forwardRef
to enable parent component to accessFloatButton
ref (link)memo
function from default export ofBackTop
component to avoid warning in development mode (link)BackTop
component and remove unused imports inFloatButtonGroup
component (link,link)interface.ts
file to store common types forFloatButton
component and related components (link,link,link)