[pull] master from ant-design:master #170

pull · 2023-10-21T18:21:23Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

* Revert "ci: merge preview workflows (#45276)" This reverts commit 0379ee5. * chore: clean tmp test

Fix title hierarchy Signed-off-by: wangzhihao <1269928993@qq.com>

…object (#45403)

* fix #44341 * update snapshot

* fix: add React.forwardRef to fix warning * test: add test case * Update components/float-button/interface.ts Co-authored-by: MadCcc <1075746765@qq.com> Signed-off-by: lijianan <574980606@qq.com> * fix: rename * Update components/float-button/interface.ts Co-authored-by: MadCcc <1075746765@qq.com> Signed-off-by: lijianan <574980606@qq.com> * update ref --------- Signed-off-by: lijianan <574980606@qq.com> Co-authored-by: MadCcc <1075746765@qq.com>

* ci: fix CI trigger events ref: https://nathandavison.com/blog/github-actions-and-the-threat-of-malicious-pull-requests * chore: undo previously changed job name * chore: remove redundancy logic * chore: update * chore: revert #45276 * Revert "chore: revert #45276" This reverts commit c98ebb9. * Revert "chore: update" This reverts commit c4cc117. * Revert "chore: remove redundancy logic" This reverts commit a49a658. * Revert "chore: undo previously changed job name" This reverts commit 7fa25e6. * Revert "ci: fix CI trigger events" This reverts commit 3e0a722. * Revert "ci: merge preview workflows (#45276)" This reverts commit 0379ee5. * chore: update * chore: update * chore: update * chore: update download * chore: update * chore: fix * Update preview-start.yml --------- Co-authored-by: afc163 <afc163@gmail.com>

Prevent keydown bug when using custom dropdown render in multiple mode Select component. Example case: when pressing backspace on inner dropdown's Input component, the selected option in the Select component also getting triggered by backspace. Signed-off-by: Gideon <106825924+gidgudgod@users.noreply.github.com>

…45454) Bumps [@types/isomorphic-fetch](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/isomorphic-fetch) from 0.0.37 to 0.0.38. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/isomorphic-fetch) --- updated-dependencies: - dependency-name: "@types/isomorphic-fetch" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs(:sparkles:): release 5.10.2 * Update CHANGELOG.zh-CN.md Co-authored-by: lijianan <574980606@qq.com> Signed-off-by: afc163 <afc163@gmail.com> * Apply suggestions from code review Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: lijianan <574980606@qq.com>

* chore: load home page component lazily * chore: improve home page blur style in Chrome

restack-app · 2023-10-21T18:21:29Z

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

commit-lint · 2023-10-21T18:21:29Z

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

pr-code-reviewer · 2023-10-21T18:21:31Z

👋 Hi there!

Everything looks good!

_{^{Automatically generated with the help of gpt-3.5-turbo.

Feedback? Please don't hesitate to drop me an email at webber@takken.io.}}

github-actions · 2023-10-21T18:21:36Z

Hi @pull[bot]。

请注意，当前 PR 是分支间的互相合并，请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash。

instapr · 2023-10-21T18:21:37Z

Thank you for the pull request. Here are a few suggestions for improvement:

Please provide more details in the PR description to help reviewers understand the changes made.
Consider adding comments in the code to explain your thought process or any complex logic.
Ensure the pull request adheres to our code style guidelines.

Let me know if you have any questions. Thanks!

github-actions · 2023-10-21T18:21:37Z

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

github-actions · 2023-10-21T18:21:37Z

sweep-ai · 2023-10-21T18:22:28Z

Apply Sweep Rules to your PR?

Apply: Leftover TODOs in the code should be handled.
Apply: All new business logic should have corresponding unit tests in the tests/ directory.
Apply: Any clearly inefficient or repeated code should be optimized or refactored.

pr-explainer-bot · 2023-10-21T18:23:39Z

Pull Request Review - Summary

Hey there! 👋 Here's a summary of the previous tasks and their results:

Changes

Added a new workflow called 'Preview Deploy' to build a preview site for each pull request.
Added a job called 'upstream-workflow-summary' to summarize the status of jobs in the 'Preview Build' workflow.
Added a job called 'deploy-preview' to deploy the preview site if the build was successful.
Added comments to the pull request with the preview site link and status.

Suggestions

In the setup job, line 23, the run step is using a multi-line script. It would be better to use the run step with a single-line script and use the if condition to check if the directory exists and create it if it doesn't.
In the build-site job, line 43, the run step is using a multi-line script. It would be better to use the run step with a single-line script and use the if condition to check if the cache hit is not true.
In the site-test job, line 67, the run step is using a multi-line script. It would be better to use the run step with a single-line script and use the if condition to check if the cache hit is not true.

Bugs

In the build-site job, line 43, the restore cache from package-lock.json step is missing the id field.
In the site-test job, line 67, the restore cache from package-lock.json step is missing the id field.

Improvements

In the setup job, lines 23-28, the script can be refactored for better readability:

- name: hack for single file
  run: |
    mkdir -p package-temp-dir
    cp package-lock.json package-temp-dir

In the build-site job, lines 43-48, the script can be refactored for better readability:

- name: restore cache from package-lock.json
  uses: actions/cache@v3
  with:
    path: package-temp-dir
    key: lock-${{ github.sha }}

- name: restore cache from node_modules
  uses: ...

Rating

Sorry, but I can't provide the rating for the code. You'll have to evaluate it yourself based on the criteria of readability, performance, and security.

That's it for the summary! Let me know if there's anything else I can help with. 😄

zombieJ and others added 20 commits October 17, 2023 14:05

Revert "ci: merge preview workflows" (#45380)

8cb26a6

* Revert "ci: merge preview workflows (#45276)" This reverts commit 0379ee5. * chore: clean tmp test

style: inline mode form overlap elements on the small screen (#45340)

fc5abff

fix: Notification RTL should have corrent margin (#45386)

7ceb1fb

type: Table pagination.position support none as value (#45398)

8c475a5

docs: Update migrate-less-variables.zh-CN.md (#45400)

98e3f4a

Fix title hierarchy Signed-off-by: wangzhihao <1269928993@qq.com>

fix: Table sorter tooltip cannot be open when showSorterTooltip is a …

49ef16b

…object (#45403)

chore: lock @types/react version to 18.2.29 (#45440)

029641a

chore: remove useless disabled style in Upload (#45446)

1c16788

fix: ColorPicker does not support arbitrary data-* attributes (#45413)

1203a12

* fix #44341 * update snapshot

chore: bump rc-* (#45453)

049f41c

chore: fix overview page search outline style (#45458)

29551aa

docs: improve home page banner style (#45459)

cd03c11

type: useAppProps modal type definition (#45462)

1fb8890

chore: update CHANGELOG time (#45466)

3ed45d5

chore: load home page component lazily (#45467)

fb0297f

* chore: load home page component lazily * chore: improve home page blur style in Chrome

github-actions bot closed this Oct 21, 2023

pull bot added the ⤵️ pull label Oct 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from ant-design:master #170

[pull] master from ant-design:master #170

pull bot commented Oct 21, 2023 •

edited

restack-app bot commented Oct 21, 2023

commit-lint bot commented Oct 21, 2023

pr-code-reviewer bot commented Oct 21, 2023 •

edited

github-actions bot commented Oct 21, 2023

instapr bot commented Oct 21, 2023

github-actions bot commented Oct 21, 2023

github-actions bot commented Oct 21, 2023 •

edited

sweep-ai bot commented Oct 21, 2023

pr-explainer-bot bot commented Oct 21, 2023

[pull] master from ant-design:master #170

[pull] master from ant-design:master #170

Conversation

pull bot commented Oct 21, 2023 • edited

restack-app bot commented Oct 21, 2023

commit-lint bot commented Oct 21, 2023

Styles

Bug Fixes

Type

Documentation

Chore

Continuous Integration

Demo

Contributors

pr-code-reviewer bot commented Oct 21, 2023 • edited

👋 Hi there!

github-actions bot commented Oct 21, 2023

instapr bot commented Oct 21, 2023

github-actions bot commented Oct 21, 2023

github-actions bot commented Oct 21, 2023 • edited

sweep-ai bot commented Oct 21, 2023

Apply Sweep Rules to your PR?

pr-explainer-bot bot commented Oct 21, 2023

Pull Request Review - Summary

Changes

Suggestions

Bugs

Improvements

Rating

pull bot commented Oct 21, 2023 •

edited

pr-code-reviewer bot commented Oct 21, 2023 •

edited

github-actions bot commented Oct 21, 2023 •

edited