Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from ant-design:master #171

Closed
wants to merge 25 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 22, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

zombieJ and others added 25 commits October 17, 2023 14:05
* Revert "ci: merge preview workflows (#45276)"

This reverts commit 0379ee5.

* chore: clean tmp test
Fix title hierarchy

Signed-off-by: wangzhihao <1269928993@qq.com>
* fix: add React.forwardRef to fix warning

* test: add test case

* Update components/float-button/interface.ts

Co-authored-by: MadCcc <1075746765@qq.com>
Signed-off-by: lijianan <574980606@qq.com>

* fix: rename

* Update components/float-button/interface.ts

Co-authored-by: MadCcc <1075746765@qq.com>
Signed-off-by: lijianan <574980606@qq.com>

* update ref

---------

Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <1075746765@qq.com>
* ci: fix CI trigger events

ref: https://nathandavison.com/blog/github-actions-and-the-threat-of-malicious-pull-requests

* chore: undo previously changed job name

* chore: remove redundancy logic

* chore: update

* chore: revert #45276

* Revert "chore: revert #45276"

This reverts commit c98ebb9.

* Revert "chore: update"

This reverts commit c4cc117.

* Revert "chore: remove redundancy logic"

This reverts commit a49a658.

* Revert "chore: undo previously changed job name"

This reverts commit 7fa25e6.

* Revert "ci: fix CI trigger events"

This reverts commit 3e0a722.

* Revert "ci: merge preview workflows (#45276)"

This reverts commit 0379ee5.

* chore: update

* chore: update

* chore: update

* chore: update download

* chore: update

* chore: fix

* Update preview-start.yml

---------

Co-authored-by: afc163 <afc163@gmail.com>
Prevent keydown bug when using custom dropdown render in multiple mode Select component. Example case: when pressing backspace on inner dropdown's Input component, the selected option in the Select component also getting triggered by backspace.

Signed-off-by: Gideon <106825924+gidgudgod@users.noreply.github.com>
…45454)

Bumps [@types/isomorphic-fetch](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/isomorphic-fetch) from 0.0.37 to 0.0.38.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/isomorphic-fetch)

---
updated-dependencies:
- dependency-name: "@types/isomorphic-fetch"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs(:sparkles:): release 5.10.2

* Update CHANGELOG.zh-CN.md

Co-authored-by: lijianan <574980606@qq.com>
Signed-off-by: afc163 <afc163@gmail.com>

* Apply suggestions from code review

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: lijianan <574980606@qq.com>
* chore: load home page component lazily

* chore: improve home page blur style in Chrome
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@restack-app
Copy link

restack-app bot commented Oct 22, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2023

Important

Review Skipped

Reviews are disabled for bot users.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

@commit-lint
Copy link

commit-lint bot commented Oct 22, 2023

Styles

Bug Fixes

Type

Documentation

Chore

Continuous Integration

Demo

Contributors

zombieJ, Yuiai01, MadCcc, afc163, jingjing20, kiner-tang, vagusX, cheng87126, li-jia-nan, Wxh16144, gidgudgod, yoyo837, dependabot[bot], mjss, renovate[bot]

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Oct 22, 2023

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

@instapr
Copy link

instapr bot commented Oct 22, 2023

PR Comment:

The code changes look good overall. Just a few minor suggestions:

  1. In line 25 of file.js, please use single quotes instead of double quotes for consistency.
  2. In line 50 of utils.js, please refactor the method name to be more descriptive.

Other than that, everything looks great! Nice work.

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Preview Failed

@github-actions
Copy link

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@github-actions
Copy link

Hi @pull[bot]。

请注意,当前 PR 是分支间的互相合并,请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash

@github-actions github-actions bot closed this Oct 22, 2023
@sweep-ai
Copy link

sweep-ai bot commented Oct 22, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@pull pull bot added the ⤵️ pull label Oct 22, 2023
@pr-explainer-bot
Copy link

Pull Request Review Markdown Doc

Hey there! 👋 Here's a summary of the previous tasks and their results. Let's get started!

Changes

  1. Updated the Docker image from cimg/node:18.18-browsers to cimg/node:21.0-browsers in .circleci/config.yml.
  2. Removed the background and backdropFilter properties from the GroupMask component in .dumi/pages/index/components/Group.tsx.
  3. Added the Suspense component and wrapped the ComponentsBlock component in .dumi/pages/index/components/PreviewBanner/index.tsx.
  4. Updated the import statements in .dumi/pages/index/index.tsx to use React.lazy for dynamic imports.
  5. Added the Suspense component and wrapped the ComponentsList, DesignFramework, and Theme components in .dumi/pages/index/index.tsx.
  6. Added the box-shadow property to the componentsOverviewSearch class in .dumi/theme/builtins/ComponentOverview/index.tsx.
  7. Updated the skip-run-names property in .github/workflows/pr-check-ci.yml.
  8. Added the preview-start.yml file in .github/workflows/.
  9. Updated the modal type in components/app/context.ts.
  10. Added a comment in components/form/style/index.ts.

Suggestions

  1. In .circleci/config.yml, consider using a variable for the Docker image version to make it easier to update in the future.
  2. In .dumi/pages/index/components/Group.tsx, consider using CSS variables for the background and backdropFilter properties.
  3. In `.dumi/pages/index/components/PreviewBanner/index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet