type: Table pagination.position support none as value #45398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45398 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 694 694
Lines 11674 11674
Branches 3117 3117
=========================================
Hits 11674 11674 ☔ View full report in Codecov by Sentry. |
|
LGTM |
kiner-tang
approved these changes
Oct 18, 2023
This was referenced Oct 18, 2023
This was referenced Oct 21, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #45362
💡 Background and solution
📝 Changelog
pagination.positionshould accept'none'.pagination.positionTS 定义不支持'none'的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 82df0ca
This pull request improves the type definitions and usage of table pagination in the Table component and its demos. It adds a new option for
TablePaginationPositionto hide pagination, fixes some typos and imports, and refactors some code for clarity and consistency. It affects the filescomponents/table/__tests__/type.test.tsx,components/table/demo/component-token.tsx,components/table/demo/dynamic-settings.tsx,components/table/demo/pagination.tsx, andcomponents/table/interface.ts.🔍 Walkthrough
🤖 Generated by Copilot at 82df0ca
nonevalue inpagination.positionprop of Table component, which hides the pagination (link, link, link, link, link)TablePaginationConfigtype fromantd/es/tablein demo files to avoid duplication and use it for definingTablePaginationPositiontype (link, link, link)TablePaginationPositiontype from demo files, as it is already defined ininterface.ts(link, link, link)topvariable in demo files to useTablePaginationPositiontype directly, without casting it (link, link)showFootervariable name in demo files for consistency and readability (link, link, link, link, link, link)describeblock for testing typescript types of Table component inside thedescribeblock for testing Table component intype.test.tsxfile, to group related tests together (link)