Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(field,utils): LightFilter中使用ProFormSelect的两个bug修复 (#7225) #7233

Merged
merged 6 commits into from
Jun 19, 2023

Conversation

SYJ0414
Copy link
Contributor

@SYJ0414 SYJ0414 commented Jun 14, 2023

#7225 两个bug修复:
问题1:feat(field): 在LightFilter中使用ProFormSelect时optionLabelProp不生效问题修复 (#7225)
问题2:feat(utils): 在LightFilter中使用ProFormSelect,label是dom元素时,回显乱码问题修复 (#7225)

…-design#7225)

在LightFilter中使用ProFormSelect时,optionLabelProp不生效问题修复
…design#7225)

在LightFilter中使用ProFormSelect时,当label是dom元素时,回显乱码成[object,object]问题修复
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

😭 Deploy PR Preview failed.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 93.42% and project coverage change: -0.03 ⚠️

Comparison is base (5d4c17b) 98.06% compared to head (bf46957) 98.04%.

❗ Current head bf46957 differs from pull request most recent head d300e85. Consider uploading reports for the commit d300e85 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7233      +/-   ##
==========================================
- Coverage   98.06%   98.04%   -0.03%     
==========================================
  Files         338      338              
  Lines       11133    11175      +42     
  Branches     4142     4037     -105     
==========================================
+ Hits        10918    10956      +38     
- Misses        178      181       +3     
- Partials       37       38       +1     
Impacted Files Coverage Δ
packages/form/src/layouts/QueryFilter/index.tsx 97.93% <ø> (ø)
packages/layout/src/ProLayout.tsx 97.81% <ø> (ø)
packages/provider/src/locale/ja_JP.tsx 100.00% <ø> (ø)
packages/table/src/Table.tsx 98.60% <ø> (ø)
packages/table/src/utils/columnRender.tsx 100.00% <ø> (+1.78%) ⬆️
...utils/src/components/InlineErrorFormItem/index.tsx 92.85% <81.25%> (-4.71%) ⬇️
packages/utils/src/components/FieldLabel/index.tsx 98.70% <87.50%> (-1.30%) ⬇️
packages/table/src/utils/cellRenderToFromItem.tsx 99.08% <88.88%> (-0.92%) ⬇️
packages/field/src/components/Cascader/index.tsx 100.00% <100.00%> (ø)
packages/field/src/components/Checkbox/index.tsx 97.61% <100.00%> (+0.05%) ⬆️
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chenshuai2144 chenshuai2144 merged commit b3050e4 into ant-design:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants