Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: highlight scroll error #37

Merged
merged 2 commits into from
Jun 18, 2023
Merged

🐛 fix: highlight scroll error #37

merged 2 commits into from
Jun 18, 2023

Conversation

rdmclin2
Copy link
Member

修复高亮组件默认不滚动问题

@rdmclin2 rdmclin2 requested a review from arvinxx June 17, 2023 15:53
@github-actions
Copy link

github-actions bot commented Jun 17, 2023

🎊 PR Preview 619af28 has been successfully built and deployed to https://ant-design-pro-editor-preview-pr-37.surge.sh

🕐 Build time: 208.04s

🤖 By surge-preview

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9762c0e) 88.25% compared to head (619af28) 88.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         315      315           
  Lines       19374    19375    +1     
  Branches      943      943           
=======================================
+ Hits        17098    17099    +1     
  Misses       2276     2276           
Impacted Files Coverage Δ
src/Highlight/style.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arvinxx arvinxx merged commit a313ceb into main Jun 18, 2023
@arvinxx arvinxx deleted the fix/highlight-scroll branch June 18, 2023 03:29
github-actions bot pushed a commit that referenced this pull request Jun 18, 2023
### [Version&nbsp;0.4.2](v0.4.1...v0.4.2)
<sup>Released on **2023-06-18**</sup>

#### 🐛 修复

- Highlight scroll error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* Highlight scroll error, closes [#37](#37) ([a313ceb](a313ceb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@github-actions
Copy link

🎉 This PR is included in version 0.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jun 18, 2023
## [Version&nbsp;0.5.0-alpha.8](v0.5.0-alpha.7...v0.5.0-alpha.8)
<sup>Released on **2023-06-18**</sup>

#### 🐛 修复

- Highlight scroll error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* Highlight scroll error, closes [#37](#37) ([a313ceb](a313ceb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@github-actions
Copy link

🎉 This PR is included in version 0.5.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

rdmclin2 added a commit that referenced this pull request Aug 26, 2023
* 🐛 fix: highlight scroll error

* 📸 chore: update snapshot

---------

Co-authored-by: rdmclin2 <rdmclin2@gmial.com>
rdmclin2 pushed a commit that referenced this pull request Aug 26, 2023
### [Version&nbsp;0.4.2](v0.4.1...v0.4.2)
<sup>Released on **2023-06-18**</sup>

#### 🐛 修复

- Highlight scroll error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* Highlight scroll error, closes [#37](#37) ([a313ceb](a313ceb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
rdmclin2 pushed a commit that referenced this pull request Aug 26, 2023
## [Version&nbsp;0.5.0-alpha.8](v0.5.0-alpha.7...v0.5.0-alpha.8)
<sup>Released on **2023-06-18**</sup>

#### 🐛 修复

- Highlight scroll error.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* Highlight scroll error, closes [#37](#37) ([a313ceb](a313ceb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
## [Version&nbsp;0.2.0](v0.1.1...v0.2.0)
<sup>Released on **2023-08-28**</sup>

#### ✨ 新特性

- **component-asset**: CreateUseAssetStore 方法支持导出 AssetProvider, 优化 createTestAssetStore ,便于下游测试, 添加 createTestAssetStore 方法,便于下游测试.
- **pro-editor**: 增加 updateCanvasInteraction 方法, 支持 getCanvasInteraction,并调整 store set、get 命名风格, 支持撤销重做, 支持配置 ProEditorStore 在devtools 中的名称.
- **sortable-list**: 导出 SortableListDispatchPayload 类型定义.
- **sortable-tree**: 支持禁用拖拽功能, 新增 sortableRule 函数规则,控制拖动排序.
- Add ActinGroup Components, add c2d2c getDiffPropsWithSchema and getSymbolMasterNameFromProps func, add field component, add more ActionGroup api support & style update, add more antd temple components, SortableList support onChange event, support undo/redo for ProEditor, update Action Css Transition, update snapshot, 完善 AssetStore 数据链路, 实现 AssetStore 与 EditorStore 的状态自动同步, 新增 ContextMenu 组件, 新增 LevaPanel 属性面板, 重构优化 ComponentAsset store 实现,收敛 AssetStore 的定义方式.

#### 🐛 修复

- **awareness**: 修正类型导出问题, 兼容服务端渲染.
- **component-asset**: 修正 AssetSchema 类型, 修正 CreateAssetStore 的类型,对齐到 ProEditorInstance, 修正类型.
- **excel-table**: 修正 Hansontable 在 server 端的兼容性问题, 修正 Hansontable 在 server 端的兼容性问题.
- **pro-editor**: 修正与 assetStore 的数据同步问题, 调整 devtools api 名称.
- **sortable-list**: 兼容默认数据展示.
- **sortable-tree**: 修正 ReactNodeProps 方法类型定义, 修正 SortableTree 在 server 端的兼容性问题, 修正 SortableTree 在 server 端的兼容性问题.
- **use-proeditor**: 修正 togglePanelExpand 方法缺失的 bug.
- Fix avatar key, fix config update, fix Input ref props, fix miss deps, github pages css style lost, highlight scroll error, refactor with zustand v4.4 equalFn, remove lucide icon, SortableList 默认空数据处理, test case error, test snapshot udpate, update snapshot, update snapshot, update snapshot, upgrade zustand version, 优化 Input 和 InputNumber 组件的受控变更逻辑, 修正潜藏的 undo/redo bug,并补充单测, 将 antd-style 设为 peer,修正 ThemeProvider 多实例问题, 将 handsontable 模块异步导入,解决 SSR 下无法使用的问题.

#### 💄 样式

- **leva-panel**: 添加 style 与 className 属性.
- Update empty style.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **component-asset**: CreateUseAssetStore 方法支持导出 AssetProvider ([d33a8b3](d33a8b3))
* **component-asset**: 优化 createTestAssetStore ,便于下游测试 ([e58eb84](e58eb84))
* **component-asset**: 添加 createTestAssetStore 方法,便于下游测试 ([60fb2c8](60fb2c8))
* **pro-editor**: 增加 updateCanvasInteraction 方法 ([8bf85d4](8bf85d4))
* **pro-editor**: 支持 getCanvasInteraction,并调整 store set、get 命名风格 ([c673970](c673970))
* **pro-editor**: 支持撤销重做 ([28a71a3](28a71a3))
* **pro-editor**: 支持配置 ProEditorStore 在 devtools 中的名称 ([2cedbb3](2cedbb3))
* **sortable-list**: 导出 SortableListDispatchPayload 类型定义 ([f47782b](f47782b))
* **sortable-tree**: 支持禁用拖拽功能 ([9a00235](9a00235))
* **sortable-tree**: 新增 sortableRule 函数规则,控制拖动排序, closes [#46](#46) ([e941865](e941865))
* Add ActinGroup Components ([231d713](231d713))
* Add c2d2c getDiffPropsWithSchema and getSymbolMasterNameFromProps func, closes [#52](#52) ([aa62185](aa62185))
* Add field component, closes [#49](#49) ([dfdfd16](dfdfd16))
* Add more ActionGroup api support & style update ([16e5dbc](16e5dbc))
* Add more antd temple components ([e99d7b7](e99d7b7))
* SortableList support onChange event ([663846c](663846c))
* Support undo/redo for ProEditor ([c88698a](c88698a))
* Update Action Css Transition ([971f090](971f090))
* Update snapshot ([6ee7422](6ee7422))
* 完善 AssetStore 数据链路 ([eefef20](eefef20))
* 实现 AssetStore 与 EditorStore 的状态自动同步 ([7135040](7135040))
* 新增 ContextMenu 组件 ([6fa1558](6fa1558))
* 新增 LevaPanel 属性面板 ([b7b0633](b7b0633))
* 重构优化 ComponentAsset store 实现,收敛 AssetStore 的定义方式 ([6a74062](6a74062))

#### What's fixed

* **awareness**: 修正类型导出问题 ([650ef65](650ef65))
* **awareness**: 兼容服务端渲染 ([1c04874](1c04874))
* **component-asset**: 修正 AssetSchema 类型 ([5ba08b6](5ba08b6))
* **component-asset**: 修正 CreateAssetStore 的类型,对齐到 ProEditorInstance ([769cf39](769cf39))
* **component-asset**: 修正类型 ([4cede56](4cede56))
* **excel-table**: 修正 Hansontable 在 server 端的兼容性问题 ([c4647d5](c4647d5))
* **excel-table**: 修正 Hansontable 在 server 端的兼容性问题 ([7c91c42](7c91c42))
* **pro-editor**: 修正与 assetStore 的数据同步问题 ([67735e2](67735e2))
* **pro-editor**: 调整 devtools api 名称 ([10f1529](10f1529))
* **sortable-list**: 兼容默认数据展示 ([58a3a15](58a3a15))
* **sortable-tree**: 修正 ReactNodeProps 方法类型定义 ([c4024cc](c4024cc))
* **sortable-tree**: 修正 SortableTree 在 server 端的兼容性问题 ([9e55c9f](9e55c9f))
* **sortable-tree**: 修正 SortableTree 在 server 端的兼容性问题 ([7c0905e](7c0905e))
* **use-proeditor**: 修正 togglePanelExpand 方法缺失的 bug ([169338b](169338b))
* Fix avatar key ([26df41f](26df41f))
* Fix config update ([2a3bbf3](2a3bbf3))
* Fix Input ref props ([da05109](da05109))
* Fix miss deps ([0c6f659](0c6f659))
* Github pages css style lost, closes [#15](#15) ([edf7355](edf7355))
* Highlight scroll error, closes [#37](#37) ([5abf169](5abf169))
* Refactor with zustand v4.4 equalFn ([0559103](0559103))
* Remove lucide icon ([b946ce3](b946ce3))
* SortableList 默认空数据处理 ([07bda12](07bda12))
* Test case error ([8e9a930](8e9a930))
* Test snapshot udpate, closes [#53](#53) ([d551f68](d551f68))
* Update snapshot ([dbe098e](dbe098e))
* Update snapshot ([511defb](511defb))
* Update snapshot ([53e7dfb](53e7dfb))
* Upgrade zustand version ([1fc2daa](1fc2daa))
* 优化 Input 和 InputNumber 组件的受控变更逻辑, closes [#45](#45) ([e1c7d4f](e1c7d4f))
* 修正潜藏的 undo/redo bug,并补充单测 ([d1e3cc1](d1e3cc1))
* 将 antd-style 设为 peer,修正 ThemeProvider 多实例问题 ([4ab40d7](4ab40d7))
* 将 handsontable 模块异步导入,解决 SSR 下无法使用的问题 ([ab69afd](ab69afd))

#### Styles

* **leva-panel**: 添加 style 与 className 属性 ([7a55431](7a55431))
* Update empty style ([e770ecb](e770ecb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants