Fix Reconnect Crash By Removing Waiting For WebSocket Connection #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do not review yet this actually didnt solve the bug. |
|
more changes added. segmentation fault fixed. i performed some comprehensive testing on my side and it worked fine. its reviewable now. @burak-58 |
added 2 commits
May 21, 2024 15:44
connected. faster reconnection for play.
lastpeony
force-pushed
the
reconnectCrashFix
branch
2 times, most recently
from
816bb73
to
33b8128
Compare
lastpeony
force-pushed
the
reconnectCrashFix
branch
from
33b8128
to
278d0d8
Compare
|
This PR is refactored and broken down to smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call init by default on webrtcClieint initialization
Call init inside publish/play only if sdk is closed previously.(stop called)
Remove waiting for WS connection with thread.sleep, move to callback style
ant-media/Ant-Media-Server#6100
reconnection rewritten
segmentation fault crash fixed
waiting for ws connection removed. ANR crash due to it fixed.
by default reconnection is enabled
users can call publish/play consequently many times, even if ws is not connected.