Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we require QuietBootstrap.php using composer #36

Closed
robbie-cahill opened this issue Feb 10, 2016 · 0 comments
Closed

Should we require QuietBootstrap.php using composer #36

robbie-cahill opened this issue Feb 10, 2016 · 0 comments

Comments

@robbie-cahill
Copy link

Should we require QuietBootstrap.php using composer? Patchwork works best when required before everything else (i.e. in the phpunit bootstrap file).

I think it should be up to the developer where to require it. If its required twice, you can have issues (see #34).

But then if you require it with composer, it will run with everything, not just when you need it (like phpunit).

I think we should remove

"autoload": { "files": ["src/QuietBootstrap.php"] }

from composer.json and just let developers require Patchwork.php manually, as per the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants