Fix compilation warning due to missing base_tester
destructor.
#340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_tester
used to have an empty virtual destructor:virtual ~base_tester() {}
. Having a destructor disables the implicit move constructor.My
savanna_cluster
hastester
as a base class of its node. It is convenient because we can call all thetester
methods directly.However, in a recent change as a PR review request, I updated the nodes from the
savanna_cluster
to be stored in astd::vector
instead of astd::array
.std::vector
requires its elements to have a default and a move constructor.To address this issue, in the recently merged PR, I removed
virtual ~base_tester() {}
, which has the side effect of re-enabling the default move constructor, sosavanna_cluster
compiled fine. However it created compilation warnings in other tests such as:This PR adds back the explicit empty destructor in
base_tester
, as well as the two required defaulted constructors. Everything now compiles without tester-related warnings.