Fix starting from snapshot created during transition #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Jul 11, 2024
|
|
linh2931
reviewed
Jul 13, 2024
libraries/chain/controller.cpp
Outdated
| // before transition_to_savanna is called. | ||
| const bool skip_validate_signee = true; // validated already | ||
| dlog("Create irreversible transition block ${bn}", ("bn", legacy_root->block_num())); | ||
| auto new_bsp = block_state::create_transition_block( |
There was a problem hiding this comment.
new_bsp can be named as new_root. But not a big deal.
linh2931
approved these changes
Jul 13, 2024
greg7mdp
approved these changes
Jul 15, 2024
|
Note:start |
…m() to that value
…after every apply_block
linh2931
approved these changes
Jul 18, 2024
greg7mdp
reviewed
Jul 18, 2024
greg7mdp
approved these changes
Jul 18, 2024
greg7mdp
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix starting from snapshot created during transition when no block log is provided.
Add new test case that starts from a snapshot created during transition after removing the block log.
Resolves #345