Skip to content

don't use a VLA to avoid clang warning #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

don't use a VLA to avoid clang warning #393

merged 1 commit into from
Jul 23, 2024

Conversation

spoonincode
Copy link
Member

clang18 flags this with warning: variable length arrays in C++ are a Clang extension.

@spoonincode spoonincode merged commit 2f5196f into main Jul 23, 2024
@spoonincode spoonincode deleted the novla branch July 23, 2024 17:44
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: INTERNALS
summary: Do not use variable length arrays to avoid clang warning.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

+1 more reviewer

@heifner heifner heifner approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spoonincode @ericpassmore @greg7mdp @heifner