Skip to content

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 31, 2024

  • Add missing mutex to fork_database_t::has_root().
  • When a block fails to produce, do not attempt to produce until the next block time stamp. This prevents a tight spin on failures. We had an issue somewhere for this, but can't find it. I found the problem when testing a possible alternative to [1.0-beta4] Misc improvements #448.
  • Refactors terminate-at-block handling into a function.
  • Additional std::move in assemble block.
  • Logging improvements
    • Do not log expired transaction count during replay.
    • Do not log expired transaction count if there are none.
    • Remove confusing "maybe switch forks" log statement.
    • Log block timestamp instead of wall clock time (which is always logged anyway) during start block.

Merges release/1.0-beta4 into main including #451

@heifner heifner changed the title [1.0-beta4] Some misc improvements [1.0-beta4 -> main] Some misc improvements Jul 31, 2024
@heifner heifner requested review from greg7mdp and linh2931 July 31, 2024 18:06
@heifner heifner added the OCI Work exclusive to OCI team label Jul 31, 2024
@heifner heifner merged commit 3947f2e into main Jul 31, 2024
36 checks passed
@heifner heifner deleted the misc-main branch July 31, 2024 19:15
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: INTERNALS
summary: Improvements to Finalizer, ForkDB, and Controller. Refactors code for readability, adds logging, and improves concurrency with additional mutex.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants