-
Notifications
You must be signed in to change notification settings - Fork 15
Pause production when not receiving votes #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… or paused production
Note:start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not done yet. Just post comments so far.
return (_is_producer_active_finalizer && | ||
_accepted_block_time - last_producer_vote_received > _production_pause_vote_timeout) | ||
|| (_other_active_finalizers && | ||
_accepted_block_time - last_other_vote_received > _production_pause_vote_timeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an issue, but I liked the previous version better. Here we can have negative time values and I think it is less clear.
Updates integration tests to use producer names for finalizer descriptions to match what core system contract does and what
producer_plugin
now expects.Updated vote signal to include the active finalizer authority and/or the pending finalizer authority
producer_plugin
could track the BLS public keys of the active and pending finalizer policies and see if the those vote BLS public keys match any of the producer account names of the finalizers with the same name <=> description. I thought it was nice to signal the finalizer authority. For one thing, we can now log the finalizer description of the vote instead of just the BLS public key. However, if we think the overhead of this is too much I could pull it out and go with the producer plugin doing all the heavy lifting.New config option
production-pause-vote-timeout-ms
Resolves #495