IF: Move create and send vote off the main thread #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made this Draft. Waiting on update to finalizer tests that are in progress #47. |
greg7mdp
approved these changes
Apr 29, 2024
libraries/chain/controller.cpp
Outdated
| @@ -3903,19 +3909,29 @@ struct controller_impl { | |||
| } | |||
| } | |||
|
|
|||
| void consider_voting(const block_state_legacy_ptr&) {} | |||
|
|
|||
| enum class main_thread_t { no, yes }; | |||
There was a problem hiding this comment.
I think it would be a little bit clearer to have the type named enum use_thread_pool_t { no, yes }; so it describes the desired behavior rather than the context of the call.
greg7mdp
approved these changes
Apr 30, 2024
linh2931
approved these changes
May 1, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vote-threads=0works for a finalizer without a producer.Resolves #58