Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the necessary changes to the vue-youtube for it to work with Vue3.
Ignore the changes to the ./dist folder, I made those for my own project so I could continue using the component while the package gets updated, as I was unable to quickly get the rollup build to work with vue#. But Vue3 drops the support for older browsers anyway, so worth thinking about which bundles are needed.
Important changes are these:
beforeDestroy
->beforeUnmount
render(h) { return h('div'); }
usingrender () { return h('div') }
andimport { h } from 'vue'
I guess this should be a tagged release in a new major version to keep the vue2 release as well.
Oh, and a side note on using the fork/PR version already. When using the plugin locally in components, i was using it in vue2 like this:
import { Youtube } from 'vue-youtube';
but since i did not use the rollup to do the release, rather just copied the component to dist as modern browsers can handle it, then you can use the component locally like this:
import Youtube from 'vue-youtube';