Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows 10 breaking #1

Closed
alexanderniebuhr opened this issue May 3, 2021 · 3 comments
Closed

windows 10 breaking #1

alexanderniebuhr opened this issue May 3, 2021 · 3 comments

Comments

@alexanderniebuhr
Copy link
Contributor

see attached video

2021-05-03_08-10-01.mp4
@alexanderniebuhr alexanderniebuhr changed the title windows breaking windows 10 breaking May 3, 2021
@antfu
Copy link
Owner

antfu commented May 3, 2021 •
edited
Loading

But using the plain electron will use the global one and require users to install it separately. Also seeing the frame does not go frameless. I am not familiar with Electron that much and does not have a Windows PC with me, if someone have one and figured out how to solve it, I will be appreciated to receive a PR. Thanks

@alexanderniebuhr
Copy link
Contributor Author

I can help. Just very busy atm.. I'll try to split into two PR.. one for frameless other for exec :)

@alexanderniebuhr
Copy link
Contributor Author

#2 for frameless fix
#3 for npx run fix

@antfu antfu closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antfu @alexanderniebuhr