Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create qbittorrent-4.3.3.client #119

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

JourneyOver
Copy link
Contributor

the qbittorrent.sh script is broken currently due to changes on qbittorrents side for the version information.. I have already fixed it myself on my side of things, if you want the changes let me know so I can bring changes over to your side as well.

the qbittorrent.sh script is broken currently due to changes on qbittorrents side for the version information.. I have already fixed it myself on my side of things, if you want the changes let me know so I can bring changes over to your side as well.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 303

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 86.738%

Files with Coverage Reduction New Missed Lines %
src/main/java/org/araymond/joal/core/ttorrent/client/Client.java 1 86.49%
Totals Coverage Status
Change from base Build 302: -0.05%
Covered Lines: 1622
Relevant Lines: 1870

💛 - Coveralls

@anthonyraymond
Copy link
Owner

Great, i'd like to merge the fix for the script as well :D

@anthonyraymond anthonyraymond merged commit 8b57d57 into anthonyraymond:master Jan 21, 2021
@JourneyOver JourneyOver deleted the qbit-4.3.3 branch January 21, 2021 22:53
@JourneyOver
Copy link
Contributor Author

@anthonyraymond Could of waited for me to commit it in with this PR so they would of both been merged in with one PR instead of two.. but oh well PR #120 has said fix.

@anthonyraymond
Copy link
Owner

Not a big deal; github pays for the extra line in database ^^.

But i prefer to keep thinkgs splitted, merge commits are more explicits:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants