Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider aliasing className #411

Open
ghost opened this issue Mar 5, 2016 · 2 comments
Open

consider aliasing className #411

ghost opened this issue Mar 5, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 5, 2016

Upstream in hyperx land, I merged a patch so that people won't have to use className in their template strings, but this broke the deku example for using class= in the code which is now aliased to className, which all the other hyperscript-style APIs appear to support. Several of the other APIs only support html element attributes like className, so I really can't win here without bothering somebody.

Would deku folk be open to aliasing className to class? Not because people should be writing className themselves, but because it helps with interoperability with the rest of the ecosystem.

Related: choojs/hyperx#22

@rstacruz
Copy link
Collaborator

rstacruz commented Mar 5, 2016

I have no opinion on the matter, but curious: have you tried asking React if they'd be open to aliasing class as className?

@anthonyshort
Copy link
Owner

Yeah this is fine by me. It's a really small change for us. The React people would probably have a ton of stuff to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants