Fix: Config page not visible #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Config to plugins.xml as applicationConfigurable extension
Closed
|
@anthraxx Upon further testing, this PR makes the config page visible, but the config page displays default values, not current values. Changes made on the config page are saved, but re-opening the config page does not show the new changes. Unfortunately I do not know enough about the SDK to fix this issue |
|
@holycrepe thanks for the feedback, I will be able to have a look on sunday and see if i can release a new version with some of the important fixes. |
|
any chance to merge this? |
|
applied in master. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Config to plugins.xml as applicationConfigurable extension