Update to use new antidot framework package #33

kpicaza · 2021-11-27T23:59:00Z

I'm not sure to merge this PR right now, it will break the current starter with 0.x versions. Maybe the best action will be to release the Framework package 1.0.0 as is, and create the Antidot Framework 2 version with the rewrite(merge against 3.x.x instead of 2.x.x see antidot-framework/antidot-framework#41), this way, we can leave the starter 1.0.0 as is, and merge this PR against 3.x.x to create the 2.0.0 version, what do you think about?

peter279k · 2021-11-28T13:18:44Z

bin/console

+$_SERVER['APP_RUNTIME'] = AntidotRuntime::class;
+$_SERVER['APP_RUNTIME_OPTIONS'] = [
+    'host' => '0.0.0.0',
+    'port' => 3000,


I think we should let 3000 port number be used before running the development server.

Or we can have the setting to set these application runtime options.

It should be configurable from the config 100%

Done, now the server is configured as every other component at config/services/dependencies.prod.yaml

peter279k · 2021-11-28T14:22:19Z

bin/console

@@ -4,13 +4,25 @@
 declare(strict_types=1);

 use Antidot\Cli\Application\Console;
+use Antidot\Framework\Runtime\AntidotRuntime;
+
+ini_set('memory_limit', '2048M');


Is this memory setting configurable?

Yes I put 2048M because when hitting a stress test with concurrency it reaches the default memory limit, it should be configurable by framework config too

take a look at the-benchmarker/web-frameworks#4640

peter279k · 2021-11-30T01:57:53Z

composer.json

-        "wshafer/psr11-monolog",
-        "laminas/laminas-httphandlerrunner",
-        "laminas/laminas-diactoros"
+        "wshafer/psr11-monolog"
      ]
    }
  }


Should we need to add the Composer script about running development server easily?

And I think it can let Quick Start be a Composer script.

It could be something like:

composer dev-server

According to this composer.json script, I think we can define and use composer run dev-server to complete this issue.

We should document this:

You can run default host by running:

composer run dev-server

Or run it in custom host by

APP_HOST=127.0.0.1:8080 composer run dev-server

xserrat

🚀 🚀

xserrat · 2021-12-04T17:56:29Z

public/index.php

+
+require_once $rootDir . '/vendor/autoload_runtime.php';
+
+return static function () use ($rootDir) {


Suggested change

return static function () use ($rootDir) {

return static function (): ContainerInterface use ($rootDir) {

xserrat · 2021-12-04T17:56:56Z

src/Application/Http/Handler/HomePage.php

 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\RequestHandlerInterface;
-use Laminas\Diactoros\Response\JsonResponse;

 class HomePage implements RequestHandlerInterface


Suggested change

class HomePage implements RequestHandlerInterface

final class HomePage implements RequestHandlerInterface

xserrat · 2021-12-04T18:03:48Z

I'm not sure to merge this PR right now, it will break the current starter with 0.x versions. Maybe the best action will be to release the Framework package 1.0.0 as is, and create the Antidot Framework 2 version with the rewrite(merge against 3.x.x instead of 2.x.x see antidot-framework/antidot-framework#41), this way, we can leave the starter 1.0.0 as is, and merge this PR against 3.x.x to create the 2.0.0 version, what do you think about?

I think it's a good idea to only maintain the old version for possible vulnerability issues or bugs. Then, the people who want to use the new version I'll use the new tag v3.0. I don't know if it should be Antidot Framework 3 if the branch is 3.x.x. What do you think?

kpicaza · 2021-12-04T19:04:49Z

@xserrat @peter279k I'm not sure about branching convention, I'm following the next logic:

0.x.x tags were made against 1.x.x branch
1.x.x tags against 2.x.x branch
so 2.x.x tags against 3.x.x

Maybe is not correct and it should be

0.x.x and 1.x.x tags on 1.x.x branch
so 2.x.x to 2.x.x
...

xserrat · 2021-12-04T19:43:40Z

@xserrat @peter279k I'm not sure about branching convention, I'm following the next logic:

0.x.x tags were made against 1.x.x branch

1.x.x tags against 2.x.x branch

so 2.x.x tags against 3.x.x

Maybe is not correct and it should be

0.x.x and 1.x.x tags on 1.x.x branch

so 2.x.x to 2.x.x

...

Oh, I see. I guess it's also good this convention. It's like all the commits/tags to reach the version <branch_name> are in that branch. For me it's ok, I don't know if it's an standard or not but it makes sense.

kpicaza · 2021-12-06T12:32:59Z

Recently released the dispatcher with the async options. I should do the same with a monolog log handler to ensure that the default pipeline middleware is not blocking the event loop. I have to dig more in-depth into how to write a file using ReactPHP.

I know that writing a file without blocking the event loop is a historical problem on async PHP, but I think that the ReactPHP and Amp people have solved it already;-D.

update to use new antidot framework package

d8e83c6

kpicaza force-pushed the starter-async branch from 99de036 to d8e83c6 Compare November 28, 2021 10:08

kpicaza changed the title ~~Remove cached file and add missed class on config~~ Update to use new antidot framework package Nov 28, 2021

kpicaza requested review from peter279k and xserrat November 28, 2021 10:09

kpicaza self-assigned this Nov 28, 2021

kpicaza added dependencies Pull requests that update a dependency file enhancement New feature or request labels Nov 28, 2021

peter279k reviewed Nov 28, 2021

View reviewed changes

Use new Antidot Runtime component

676e49e

kpicaza changed the base branch from 2.x.x to 3.x.x November 28, 2021 18:38

Set up inital config

53626c5

peter279k reviewed Nov 30, 2021

View reviewed changes

Add dev server shorcut in composer scripts

7b68374

xserrat approved these changes Dec 4, 2021

View reviewed changes

Be more strict on class declaration

452b2c9

kpicaza requested a review from peter279k December 4, 2021 19:40

kpicaza added 3 commits December 11, 2021 20:26

Use Monolog Echo Handler

7fa3524

Load runtime with relative path

669079d

update framework to v2.0.0 Beta 1

8959f6a

kpicaza merged commit 9d077f1 into antidot-framework:3.x.x Dec 12, 2021

kpicaza deleted the starter-async branch December 12, 2021 12:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to use new antidot framework package #33

Update to use new antidot framework package #33

kpicaza commented Nov 27, 2021 •

edited

Loading

peter279k Nov 28, 2021

kpicaza Nov 28, 2021

kpicaza Nov 28, 2021 •

edited

Loading

peter279k Nov 28, 2021

kpicaza Nov 28, 2021

kpicaza Nov 28, 2021 •

edited

Loading

peter279k Nov 30, 2021

kpicaza Nov 30, 2021

peter279k Dec 1, 2021

kpicaza Dec 1, 2021

xserrat left a comment

xserrat Dec 4, 2021

xserrat Dec 4, 2021

xserrat commented Dec 4, 2021

kpicaza commented Dec 4, 2021

xserrat commented Dec 4, 2021

kpicaza commented Dec 6, 2021


		require_once $rootDir . '/vendor/autoload_runtime.php';

		return static function () use ($rootDir) {

	return static function () use ($rootDir) {
	return static function (): ContainerInterface use ($rootDir) {

	class HomePage implements RequestHandlerInterface
	final class HomePage implements RequestHandlerInterface

Update to use new antidot framework package #33

Update to use new antidot framework package #33

Conversation

kpicaza commented Nov 27, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpicaza Nov 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpicaza Nov 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xserrat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xserrat commented Dec 4, 2021

kpicaza commented Dec 4, 2021

xserrat commented Dec 4, 2021

kpicaza commented Dec 6, 2021

kpicaza commented Nov 27, 2021 •

edited

Loading

kpicaza Nov 28, 2021 •

edited

Loading

kpicaza Nov 28, 2021 •

edited

Loading