Fix Issue113

[sunheehnus]

No description provided.

[sunheehnus]

Dummy ack job did not got removed when clusterSize is 1,

When clusterSize is 1, tryJobGC will not GC the dummy job and gotAckReceived will not be triggered either.

---

TEST CASE (a one-node cluster)

Before

127.0.0.1:7711> info jobs
# Jobs
registered_jobs:0
127.0.0.1:7711> ackjob DI77455215a7aabc748fdb448dd59bc3e891abf16905a0SQ
(integer) 0
127.0.0.1:7711> info jobs
# Jobs
registered_jobs:1

After

127.0.0.1:7711> info jobs
# Jobs
registered_jobs:0
127.0.0.1:7711> ackjob DI77455215a7aabc748fdb448dd59bc3e891abf16905a0SQ
(integer) 0
127.0.0.1:7711> info jobs
# Jobs
registered_jobs:0

[antirez]

Thanks @sunheehnus! I merged your commit, but I'm going to change a few things and comment here what I changed so that you may review. Thank you a lot as usually!

[antirez]

Just reworked a bit the fix in three commits:

d947415 Don't create a dummy ack if the cluster size is 1.
c8cc037 jscanCallback(): check for dummy job in a consistent way.
045562b Two different "all nodes reached" code paths unified in tryJobGC().

Thanks!

[sunheehnus]

All look good to me. 👍
Sorry for the delay, on a trip last 3 days without stable access to Internet. :-)