Skip to content

cpp runtime better not to define symbol in global namespace, like Ref #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byronhe opened this issue Jul 17, 2020 · 0 comments
Open

cpp runtime better not to define symbol in global namespace, like Ref #2867

byronhe opened this issue Jul 17, 2020 · 0 comments

Comments

@byronhe
Copy link

byronhe commented Jul 17, 2020

antlr defined Ref in global namespace at runtime/Cpp/runtime/src/antlr4-common.h ,
this definition caused symbol conflict with my internal codebase.

in my opinion, as a library , antrl4-cpp-runtime should not define symbols in global namespace, a better way should be include Ref in namespace like antlrcpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant