Fix missing variable declarations

[robertbrignull]

This PR adds the var keyword to three variable declarations that were missing it and implicitly declaring global variables. Note that actually in all of the cases there's a similar function nearby that does use a local variable. Also none of these changes will change the semantics of the functions.

I noticed this because when in 'use strict' mode all of these lines will cause errors saying the variable in question is not defined. This is a problem because webpack will by default apply strict mode and this is the method of distribution that users are recommended to use.

[ericvergnaud]

Blessed Envoyé de mon iPhone

…

Le 11 janv. 2017 à 23:49, Robert ***@***.***> a écrit : This PR adds the var keyword to three variable declarations that were missing it and implicitly declaring global variables. Note that actually in all of the cases there's a similar function nearby that does use a local variable. Also none of these changes will change the semantics of the functions. I noticed this because when in 'use strict' mode all of these lines will cause errors saying the variable in question is not defined. This is a problem because webpack will by default apply strict mode and this is the method of distribution that users are recommended to use. You can view, comment on, or merge this pull request online at: #1599 Commit Summary fix missing variable declarations sign contributors.txt File Changes M contributors.txt (1) M runtime/JavaScript/src/antlr4/Utils.js (2) M runtime/JavaScript/src/antlr4/atn/ParserATNSimulator.js (2) M runtime/JavaScript/src/antlr4/dfa/DFA.js (2) Patch Links: https://github.com/antlr/antlr4/pull/1599.patch https://github.com/antlr/antlr4/pull/1599.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.