Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To java 8 #3392

Closed
wants to merge 3 commits into from
Closed

To java 8 #3392

wants to merge 3 commits into from

Conversation

parrt
Copy link
Member

@parrt parrt commented Dec 5, 2021

@KvanTTT @ericvergnaud trying to see if 1.8 works.

@parrt parrt added this to the 4.9.4 milestone Dec 5, 2021
@KvanTTT
Copy link
Member

KvanTTT commented Dec 6, 2021

Unfortunately, there are problems with tests due to compilation failure.

@parrt
Copy link
Member Author

parrt commented Dec 6, 2021

yep, this is the error in maven i can't solve

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project antlr4-runtime: Compilation failure -> [Help 1]

Please note javac and intellij compile code fine with java 8

@parrt parrt changed the title To java 8 [WIP] To java 8 Dec 7, 2021
@parrt parrt changed the title [WIP] To java 8 To java 8 Dec 8, 2021
@parrt
Copy link
Member Author

parrt commented Dec 8, 2021

I am abandoning this because I cannot get 1.8 or above to work due to incompatibility with the use of internal javac lib objects. I was able to compile with 1.8 and 11 but not 17 prior to this attempt, when the source and target were left as 1.7 in the maven pom.

@parrt parrt closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants