cpp runtime: Remove pthread dependency. #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSonzogni
force-pushed
the
remove-pthread
branch
2 times, most recently
from
2285791
to
dcaa0be
Compare
|
@Krzmbrzl WDYT? |
|
Sounds good to me. Option 1) would be an issue imo, because it restricts usability of ANTLR to somewhat recent systems only. However, implementing this ourselves appears as a solid workaround for our use case 👍 |
ArthurSonzogni
force-pushed
the
remove-pthread
branch
from
dcaa0be
to
ca508be
Compare
ArthurSonzogni
added a commit
to ArthurSonzogni/Diagon
that referenced
this pull request
Jan 22, 2023
It now links against pthread, and this is not supported directly by emscriten. Downgrading the ANTLR version fixed the problem. Long-term, I submitted a PR against ANTLR to fix the issue: antlr/antlr4#4086
ArthurSonzogni
added a commit
to ArthurSonzogni/Diagon
that referenced
this pull request
Jan 22, 2023
It now links against pthread, and this is not supported directly by emscriten. Downgrading the ANTLR version fixed the problem. Long-term, I submitted a PR against ANTLR to fix the issue: antlr/antlr4#4086
ANTLR doesn't use threads, and it used not to depend on pthread library either. It changed recently in 2022: antlr#3708 The patch linked against pthread, because the GNU libstdc++ used to depend on it in their implementation of `std::call_once`. By the way, the libstdc++ stopped it in 2020: https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=93e79ed391b9c636f087e6eb7e70f14963cd10ad So this is not more needed. I would like to stop depending on pthread. I am using ANTLR in C++ WebAssembly for the website: https://arthursonzogni.com/Diagon/ It doesn't compile with emscripten anymore, because by default pthread is not enabled. It could be enabled, but it would force me to deploy cross-origin-isolation: https://web.dev/cross-origin-isolation-guide/ Solutions: 1. Stop linking against pthread, because the libstdc++ stopped depending on it for std::call_once. 2. Implement std::call_once ourself using std::atomic_flag 3. Implement std::call_once ourself using a boolean flag, assuming we don't need to support threads. I chose to do (2) in this patch. Signed-off-by: ArthurSonzogni <sonzogniarthur@gmail.com>
ArthurSonzogni
force-pushed
the
remove-pthread
branch
from
ca508be
to
d36e2b9
Compare
|
Okay. Then, I think this is ready. Thanks! |
|
Thanks! |
|
Hmm..seems we have a failure: https://github.com/antlr/antlr4/actions/runs/4031407036/jobs/6930678126 |
|
I'll retry it. |
|
Thanks for the code review! |
|
damn. this was on master not dev. |
parrt
added a commit
to parrt/antlr4
that referenced
this pull request
Feb 19, 2023
This reverts commit 2073147.
|
Can you base this on latest dev and resubmit? thanks. @ArthurSonzogni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANTLR doesn't use threads, and it used not to depend on pthread library either.
It changed recently in 2022: #3708 The patch linked against pthread, because the GNU libstdc++ used to depend on it in their implementation of
std::call_once.By the way, the libstdc++ stopped it in 2020:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=93e79ed391b9c636f087e6eb7e70f14963cd10ad So this is not more needed.
I would like to stop depending on pthread. I am using ANTLR in C++ WebAssembly for the website:
https://arthursonzogni.com/Diagon/
It doesn't compile with emscripten anymore, because by default pthread is not enabled. It could be enabled, but it would force me to deploy cross-origin-isolation:
https://web.dev/cross-origin-isolation-guide/
Solutions:
I chose to do (2) in this patch.