Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the changed line, in go, if we assign a slice position to a variable, we'll have a copy.
ki.Start = v + 1,
on line 218, was just modifying a copy, which is not what was intended to be done here.If we get the reference as done in the change, we'll modify
ki.Start
properly. Another option would be to reasign the copy to the array position. Either way, this should be fixed.Simple test which would fail: