Rename NULL, TRUE, and FALSE literals in SQLite grammar to successfully compile targeting c++ #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Oct 27, 2020
KvanTTT
added
sqlite
target:cpp
KvanTTT
reviewed
Oct 27, 2020
KvanTTT
added
the
symbol-conflict
…ly compile targeting c++ ANTLR runtime includes header files that define NULL via preprocessing directive, using NULL as an identifier in grammars (specifiecally the lexer) causes it to be used as an identifier in the corresponding autogenerated c++ code which then fails to compile. We change NULL to NULL_ in SQLiteLexer.g4 and update its use in SQLiteParser.g4. We also do the same to TRUE and FALSE to avoid similar issues that may occur when compiling on windows. This fixes antlr#1904
|
Sorry, I had originally planned to do it with just _, but the MySQL grammar you currently have uses All good now, changed my PR to use |
KvanTTT
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANTLR runtime includes header files that define NULL via preprocessing directive, using NULL as an identifier in grammars (specifically the lexer) causes it to be used
as an identifier in the corresponding auto-generated c++ code which then fails to compile.
[edited:] We change NULL to NULL_ in SQLiteLexer.g4 and update its use in SQLiteParser.g4. We also do the same to TRUE and FALSE to avoid similar issues that may occur when compiling on windows.
This fixes #1904