Changed "provence" to "provenance" #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine. The only other change I would recommend is for "commited"--it should be "committed". I'm not sure why it's not being merged. @teverett |
|
Is there something I'm supposed to do on my end? The change is committed in my fork. |
|
I just synced my fork -- maybe that's what was holding things up? |
Likely. The previous build of this PR failed because of some changes to the TypeScript/Node.js environment. That caused the "library not loaded" problem. https://github.com/antlr/grammars-v4/actions/runs/8398752211/job/23060672270#step:24:57 . I fixed that problem with a change in PR #4019 @teverett or @KvanTTT Please restart the workflow tests for this PR. Ty. |
|
@pfurbacher thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited on github (via browser). Corrected the typo. Not sure, but it looks like github's web-based editor may have changed the last line (whitespace?) when the single edit on line 5 was saved.