fix: (#84) compute aliases even if entry file is not typescript file #89
Conversation
There was a problem hiding this comment.
That was fast!
Implementation looks good, there are just two important comments to fix before merge :)
Also, could you please generate the changeset file for that PR? I don't know if you're familiar with the process, if not I can handle it.
Basically it's just about:
pnpm changeset- select
skottfor a patch update as this is a fix - write a small message describing the purpose of this fix
- commit and push the generated file
- the CI will do the rest
antoine-coulon
force-pushed
the
main
branch
5 times, most recently
from
f09567f
to
d45c114
Compare
ACHP
force-pushed
the
fix/allow-entry-point-to-be-js-with-type-aliases
branch
from
ead7e44
to
2fec3f5
Compare
There was a problem hiding this comment.
LGTM! Thanks for the contribution 🎉
@all-contributors please add @ACHP for code.
|
@all-contributors please add @ACHP for code. |
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 377 |
|
@all-contributors please add @ACHP for code. |
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 377 |
As mentionned in the following conversation, I removed the
isTypescriptModule(entryPoint)byisTypescriptProject().