Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.9 support #149

Closed
antoinecarme opened this issue Oct 2, 2020 · 4 comments
Closed

Python 3.9 support #149

antoinecarme opened this issue Oct 2, 2020 · 4 comments

Comments

@antoinecarme
Copy link
Owner

antoinecarme commented Oct 2, 2020

Check that python 3.9 is supported in pyaf.

@antoinecarme antoinecarme self-assigned this Oct 2, 2020
@antoinecarme antoinecarme changed the title Python 3.8 support. Python 3.8 support Oct 2, 2020
@antoinecarme
Copy link
Owner Author

also check latest versions of all third-party software used in pyaf : numpy, scipy, pandas, scikit-klearn, matplotlib, xgboost, etc

@antoinecarme antoinecarme changed the title Python 3.8 support Python 3.9 support Oct 13, 2020
antoinecarme added a commit that referenced this issue Dec 15, 2020
@antoinecarme
Copy link
Owner Author

See PR #152

The CI process fails when trying to use python 3.9

Fails with the following trace back :

Exception in thread Thread-3:

Traceback (most recent call last):

  File "/opt/python/3.9.0/lib/python3.9/threading.py", line 950, in _bootstrap_inner

    self.run()

  File "/opt/python/3.9.0/lib/python3.9/threading.py", line 888, in run

    self._target(*self._args, **self._kwargs)

  File "/opt/python/3.9.0/lib/python3.9/multiprocessing/pool.py", line 576, in _handle_results

    task = get()

  File "/opt/python/3.9.0/lib/python3.9/multiprocessing/connection.py", line 256, in recv

    return _ForkingPickler.loads(buf.getbuffer())

TypeError: <lambda>() takes 6 positional arguments but 7 were given

@antoinecarme
Copy link
Owner Author

antoinecarme commented Dec 25, 2020

This is probably related to the following python bug ( not fixed yet ) :

https://bugs.python.org/issue39751

multiprocessing breaks when payload fails to unpickle.

Need to analyze the pickle failure in PyAF.

antoinecarme added a commit that referenced this issue Jan 21, 2021
Avoid div by zero warning
antoinecarme added a commit that referenced this issue Jan 21, 2021
Corrected get_time_dtype
antoinecarme added a commit that referenced this issue Jan 21, 2021
Updated tests Makefile
antoinecarme added a commit that referenced this issue Jan 21, 2021
Corrected this test
antoinecarme added a commit that referenced this issue Apr 15, 2021
@antoinecarme
Copy link
Owner Author

CircleCI uses python-3.9

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant