Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Pipeline Builder and Fixes #124

Closed
wants to merge 1 commit into from

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 19, 2024

Description

Introduces a pipeline builder that composes the pipeline.

Also fixes the BatchReader to use its cursor.

Metadata

Fixes #110

Copy link
Collaborator Author

refcell commented Apr 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title feat(derive): pipeline builder feat(derive): Pipeline Builder and Fixes Apr 19, 2024
@refcell refcell requested a review from clabby April 19, 2024 17:02
@refcell refcell added K-feature Kind: feature A-derive Area: kona-derive crate labels Apr 19, 2024 — with Graphite App
@refcell refcell self-assigned this Apr 19, 2024
@refcell refcell added this to the Table Stakes milestone Apr 19, 2024
@refcell
Copy link
Collaborator Author

refcell commented Apr 19, 2024

This is failing right now because I re-introduced the breaking test.

I will fix it in this pr and add more tests on the batch queue.

@clabby clabby deleted the branch refcell/span-batch-checks April 19, 2024 18:51
@clabby clabby closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants