Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): Remove Slot Derivation #636

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(providers): Remove Slot Derivation #636

merged 1 commit into from
Oct 7, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 6, 2024

Description

Removes the SlotDerivation trait and inlines the SimpleSlotDerivation method into the OnlineBlobProvider. If it becomes needed elsewhere, we can refactor down the road to pull it out of the OnlineBlobProvider into it's own type without specifying it as a generic.

Metadata

Closes #632

@refcell refcell requested a review from clabby October 6, 2024 13:01
@refcell refcell self-assigned this Oct 6, 2024
@refcell refcell added the K-fix Kind: fix label Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.0%. Comparing base (ed6c0db) to head (1ead1dc).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/providers-alloy/src/blob_provider.rs 90.3% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 3046b06 Oct 7, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(providers): Remove SlotDerivation
2 participants