Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor): Update EIP-1559 configurability #648

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 7, 2024

Overview

Updates kona-executor's implementation of configurable EIP-1559 parameters, per the specification update in ethereum-optimism/specs#418.

Instead of using the parameters within the payload for the current block, we use the parameters encoded in the parent block header (or the canyon constants, if the parent header's nonce == 0). When encoding the parameters for placing in the header, we use the eip1559Params within the payload (or the canyon constants, if payload.eip1559Params == 0).

@clabby clabby added K-feature Kind: feature A-executor Area: kona-executor crate labels Oct 7, 2024
@clabby clabby self-assigned this Oct 7, 2024
@clabby clabby requested a review from refcell as a code owner October 7, 2024 20:51
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 20 lines in your changes missing coverage. Please review.

Project coverage is 90.3%. Comparing base (4bf4264) to head (b5d5cd0).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/lib.rs 55.5% 20 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is sound

Copy link

@cody-wang-cb cody-wang-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clabby clabby added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 5dd6f3c Oct 7, 2024
16 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants