Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0: Investigate GIT_DIR var. If works - replace __GIT_WORKING_DIR__ #262

Closed
MaxymVlasov opened this issue Oct 25, 2021 · 1 comment
Closed

2.0.0: Investigate GIT_DIR var. If works - replace __GIT_WORKING_DIR__ #262

MaxymVlasov opened this issue Oct 25, 2021 · 1 comment
Labels
breaking-changes The current implementation contains Breaking Changes / Can't be implemented without Breaking Changes estimate/2h Need 2 hours to be done
Milestone
2.0.0 [BREAKING C...

Comments

@MaxymVlasov
Copy link
Collaborator

MaxymVlasov commented Oct 25, 2021 •
edited
Loading

GIT_DIR is git native var replacement for __GIT_WORKING_DIR__.

It's simpler to read, understand and remember than __GIT_WORKING_DIR__.
Need to check that it is suitable for our needs.

Note: #264 (comment)
@MaxymVlasov MaxymVlasov added the breaking-changes The current implementation contains Breaking Changes / Can't be implemented without Breaking Changes label Oct 25, 2021
@MaxymVlasov MaxymVlasov added this to the 2.0.0 [BREAKING CHANGES] milestone Oct 25, 2021
@MaxymVlasov MaxymVlasov added estimate/1h Need 1 hour to be done good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 25, 2021
@MaxymVlasov MaxymVlasov mentioned this issue Oct 25, 2021
Closed
4 tasks
@MaxymVlasov MaxymVlasov changed the title 2.0.0: Remove __GIT_WORKING_DIR__ from tflint 2.0.0: Invastigate GIT_DIR var. If wokrs - replace __GIT_WORKING_DIR__ Oct 26, 2021
@MaxymVlasov MaxymVlasov added estimate/2h Need 2 hours to be done and removed estimate/1h Need 1 hour to be done labels Oct 26, 2021
@MaxymVlasov MaxymVlasov changed the title 2.0.0: Invastigate GIT_DIR var. If wokrs - replace __GIT_WORKING_DIR__ 2.0.0: Invastigate GIT_DIR var. If works - replace __GIT_WORKING_DIR__ Oct 26, 2021
@MaxymVlasov
Copy link
Collaborator Author

That's will not work, it searches for .git/ dir location

@yermulnik yermulnik changed the title 2.0.0: Invastigate GIT_DIR var. If works - replace __GIT_WORKING_DIR__ 2.0.0: Investigate GIT_DIR var. If works - replace __GIT_WORKING_DIR__ Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-changes The current implementation contains Breaking Changes / Can't be implemented without Breaking Changes estimate/2h Need 2 hours to be done
Projects
None yet
Milestone
2.0.0 [BREAKING CHANGES]
Development

No branches or pull requests
1 participant
@MaxymVlasov