update to the python3 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all the strings needs to be casted to binary otherwise the encryption of the channel will be broken. Did you tested the framework against any IIS webserver? |
|
I can not test it because I do not know how your project works (in the logic). |
|
so you can test my edit and if you see a problem tell me I so happy about it :D |
|
Well this is not a "repair". You just changed the parenthesis in the print and the string interpolations. All the modules code is unchanged. Anyway i don't merge untested code. If you want to contribute please ensure to test the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @antonioCoco I finished #10
:D and i liked Your project but your source needs comments
what are you think?