Support for RTL Line Numbers #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! But I decided to drop support for line numbers in Codejar. |
|
Feel free to release it as a separate package 'codejar-linenumber' and add the link to the readme here. |
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RTL line numbers via a new option (
side) whose value may be eitherleftorright.When the option is set to
left(or left un-set asleftis the default), everything works as before. When the option is set toright, the line numbers are moved to the right hand side of the editor, and thedirattribute is set tortl.A new demo has been added to the test page, as seen here:
The Arabic text in the demo page exists because many people will likely not be able to easily generate text of sufficient length to properly test the component easily. It is Arabic Lorem Ipsum.