Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked ambilight layer and added a vertical flip option #1774

Merged
merged 40 commits into from
May 7, 2020
Merged

Reworked ambilight layer and added a vertical flip option #1774

merged 40 commits into from
May 7, 2020

Conversation

diogotr7
Copy link
Collaborator

@diogotr7 diogotr7 commented Oct 28, 2019

Fixes #442

This pull request proposes the following changes:

  • Adds an option that flips the image vertically. This improves the illusion that th keyboard is reflecting the screen.
  • Changed the way the cropping is done. Before, the image was cropped differently for each screen capture mode. Now, the target screen region is calculated from the options and then applied to the layer. Should do the same thing but is a bit cleaner imo. Code review appreciated.
  • Adds the ability to display the ambilight image in a keyboard region instead of covering the whole canvas.
  • Reworks the 2 implementations of ambilight into an interface + 2 classes for better clarity.

Known issues/To do:

  • The access lost exception is still not fixed, not sure what causes this exactly,
  • Only one DX desktop duplicator layer should be active at any time. There needs to be a system trhat prevents then user from turning on the "experimental mode" if any other layer on the aplication has it turned on already.

flips the image horizontally do improve the reflection effect on the keyboard. Fixes #442
somehow it builds on my machine even though it should be using c# 7?
@diogotr7 diogotr7 marked this pull request as ready for review November 11, 2019 18:07
@diogotr7 diogotr7 changed the title Ambilight: Added a vertical flip option and cleaned up code a bit Reworked ambilight layer and added a vertical flip option Apr 5, 2020
@gitmacer
Copy link
Contributor

Instead of adding the flip option just to the ambilight layer. I would suggest to add a mirror vertically and horizontally option to the layer options here:
grafik

@gitmacer
Copy link
Contributor

  • In my opinion the Monitor selection should start at 1 instead of 0
  • Also Wibbles process picker should be used?

Wibble199
Wibble199 previously approved these changes May 7, 2020
@diogotr7 diogotr7 merged commit dc0721d into antonpup:dev May 7, 2020
@diogotr7 diogotr7 deleted the fix/ambilight branch May 7, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants