Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR: minimal changes for Windows support #2

Merged
merged 10 commits into from
Feb 27, 2022

Conversation

antonycourtney
Copy link
Owner

This branch is a minimal variant of the WindowsSupport branch, with a few key differences:

  1. The versions of various dependencies and dev-dependencies are kept the same as they are in the node-duckdb master branch.
  2. Fixed an off-by-one error in the BLOB handling code in the changes that bring addon/result_iterator.cc up to date with changes in DuckDb master.
  3. Fixed the string matched for CLOSED_RESULT_ERROR_MESSAGE to determine when a C++ exception from DuckDb should result in throwing a JS exception.
  4. A few minor changes to tests to account for changes in test output when building against DuckDb master.

@antonycourtney antonycourtney changed the title Windows minimal Draft PR: minimal changes for Windows support Feb 18, 2022
@antonycourtney antonycourtney marked this pull request as ready for review February 27, 2022 04:43
@antonycourtney antonycourtney merged commit 7fa477f into master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant