-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added example using Cambalache ui file #309
Conversation
Sorry, I forgot about this PR. How is this different that this example? |
It just uses a gtk-4.10 ui file made with Cambalache which seems to be bound to replace Glade which doesn't support gtk-4 |
It seems you forgot to add some dev-dependencies. |
fixup: dependencies -> dev-dependencies in Cargo.toml Co-authored-by: antoyo <antoyo@users.noreply.github.com>
The CI fails because of an old version of glib. runs-on: ubuntu-22.04 |
.github/workflows/CI.yml
Outdated
container: | ||
image: ubuntu:20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need to remove these two lines, otherwise, this will still run on Ubuntu 20.04, I believe.
Hmm. The last CI attempt tries to download gtk4. Is this normal? |
sounds normal to me. |
Why? relm doesn't support gtk4. If so, please add the corresponding Ubuntu package in the CI. |
I'm confused. I said that I added an example using a gtk-4 ui file. I didn't realize gtk-4 wasn't supported. Would you even want this merged, then? If so, I'll see that I make the change. |
Sorry, I forgot about this PR. Yeah, since this example very similar to the glade one and gtk-4 isn't supported, I would see little value in merging this PR. Sorry about that. |
OK, no prob. |
I would have liked to use an
AdwApplicationWindow
instead of aGtkApplicationWindow
for the root widget, but I couldn't get it to work.