Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gtk 0.18 #314

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update to gtk 0.18 #314

wants to merge 3 commits into from

Conversation

msrd0
Copy link
Contributor

@msrd0 msrd0 commented Dec 14, 2023

No description provided.

@antoyo
Copy link
Owner

antoyo commented Dec 16, 2023

It will require to update the Rust version for the CI since it's not building on 1.65 anymore (or completely remove this CI task).

@msrd0
Copy link
Contributor Author

msrd0 commented Dec 29, 2023

@antoyo Can you take a look? The CI test failure seems to be a timeout due to clicks not being emulated correctly, which happens locally when I test the master branch as well, so it doesn't seem to be something I introduced

@antoyo
Copy link
Owner

antoyo commented Jan 8, 2024

Yes, I'll look at this, but it might take a few weeks before I have some time.

In the meantime, if you want to attempt to debug this, could you please run a single test (like this one) to see if the issue is that the events are not sent correctly (e.g. the text is not input in the text box) or if that's the observers that are not triggered.

@msrd0
Copy link
Contributor Author

msrd0 commented Jan 9, 2024

When I run the tests locally and manually trigger those events, the tests finish as expected. So I believe the problem is with triggering the events.

Yes, I'll look at this, but it might take a few weeks before I have some time.

Sure, no worries.

@antoyo
Copy link
Owner

antoyo commented Apr 19, 2024

Sorry, I completely forgot about this.

As mentioned here, perhaps we should update the enigo dependency. That might require pulling gtk-test back it relm-test like it originally was since gtk-test was archived and is not updated anymore.

@antoyo antoyo mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants