Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sort-by flag in more antctl resources for more fields #1605

Closed
Dyanngg opened this issue Dec 3, 2020 · 11 comments · Fixed by #4346
Closed

Implement sort-by flag in more antctl resources for more fields #1605

Dyanngg opened this issue Dec 3, 2020 · 11 comments · Fixed by #4346
Assignees
@jainpulkit22
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Dyanngg
Copy link
Contributor

Dyanngg commented Dec 3, 2020

PR #1530 introduced the sort-by flag to the NetworkPolicy resource for antctl get command. Currently the only supported value for this flag is effectivePriority, which is computed based on the Tier priority and policy priority of each NetworkPolicy.

As pointed out in #1530 (comment), since sorting is implemented on the client side through the transform defined for each resource, we can support sort-by for an arbitrary field of the resource, or in other resources that antctl can query (e.g. appliedToGroups and addressGroups).
@Dyanngg Dyanngg added good first issue Good for newcomers kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. and removed kind/design Categorizes issue or PR as related to design. labels Dec 3, 2020
@Dyanngg Dyanngg mentioned this issue Dec 3, 2020
Merged
@saramach
Copy link

Will take this

@antoninbas
Copy link
Contributor

Thansk @saramach, I assigned this to you!

@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2021
@antoninbas antoninbas removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2021
@antoninbas
Copy link
Contributor

@saramach are you still working on this, or should I clear the Assignees field for this issue?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2022
@antoninbas antoninbas removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2022
@antoninbas
Copy link
Contributor

@saramach No update from you so I'm removing you as an Assignee in case someone else wants to work on this

@urharshitha
Copy link
Contributor

urharshitha commented Mar 11, 2022 •
edited
Loading

@antoninbas As the issue states implementing sort-by flag in more resources and more feilds ,will take this issue to implement sort-by flag in generic form like kubectl sort-by flag

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2022
@tnqn tnqn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2022
@antoninbas antoninbas removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2022
@jainpulkit22 jainpulkit22 self-assigned this Oct 27, 2022
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Oct 27, 2022
Added sort-by flag in more antctl resources.
4b9d9c4 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
@jainpulkit22 jainpulkit22 mentioned this issue Oct 27, 2022
Merged
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2023
@antoninbas antoninbas removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2023
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2023
@luolanzone luolanzone removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2023
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue May 19, 2023
Added sort-by flag in more antctl resources.
1314ad6 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 2, 2023
Added sort-by flag in more antctl resources.
9a96896 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 2, 2023
Added sort-by flag in more antctl resources.
2c3715b 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 2, 2023
Added sort-by flag in more antctl resources.
57fc602 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 2, 2023
Added sort-by flag in more antctl resources.
4cfdde3 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 2, 2023
Added sort-by flag in more antctl resources.
7014441 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 6, 2023
Add sort-by flag in more antctl resources
9c48cfd 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 6, 2023
Add sort-by flag in more antctl resources
5b5dfef 
Fixes antrea-io#1605.

Added sort by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(UID), appliedtogroup(UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 6, 2023
Add sort-by flag in more antctl resources
2743819 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 7, 2023
Add sort-by flag in more antctl resources
c20772c 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 7, 2023
Add sort-by flag in more antctl resources
12a7010 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID),
addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 8, 2023
Add sort-by flag in more antctl resources
571e2cd 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID,
effectivePriority), addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 8, 2023
Add sort-by flag in more antctl resources
46ff789 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID,
effectivePriority), addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 12, 2023
Add sort-by flag in more antctl resources
1a62fd2 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID,
effectivePriority), addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 12, 2023
Add sort-by flag in more antctl resources
dc2bcde 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID,
effectivePriority), addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 12, 2023
Add sort-by flag in more antctl resources
8f24d2c 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy(creationTimestamp, Name, UID,
effectivePriority), addressgroup(creationTimestamp, Name, UID),
appliedtogroup(creationTimestamp, Name, UID).

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 15, 2023
Add sort-by flag in more antctl resources
94304b5 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 15, 2023
Add sort-by flag in more antctl resources
26af4d6 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 16, 2023
Add sort-by flag in more antctl resources
0d7f10c 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 16, 2023
Add sort-by flag in more antctl resources
83c1eef 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 20, 2023
Add sort-by flag in more antctl resources
4672969 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 21, 2023
Add sort-by flag in more antctl resources
6e94735 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jun 21, 2023
Add sort-by flag in more antctl resources
1b40da8 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jul 4, 2023
Add sort-by flag in more antctl resources
b87a060 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jul 4, 2023
Add sort-by flag in more antctl resources
32ea1bd 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
jainpulkit22 pushed a commit to jainpulkit22/antrea that referenced this issue Jul 5, 2023
Add sort-by flag in more antctl resources
5eea7b9 
Fixes antrea-io#1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
tnqn pushed a commit that referenced this issue Jul 10, 2023
@jainpulkit22
Add sort-by flag in more antctl resources (#4346)
688d189 
Fixes #1605.

Added sort-by flag for networkpolicy, addressgroup, and
appliedtogroup resource.

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainpulkit22 jainpulkit22

Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sort-by flag in more antctl resources for more fields jainpulkit22/antrea
7 participants
@antoninbas @tnqn @Dyanngg @saramach @jainpulkit22 @urharshitha @luolanzone