Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure appliedTo and priority is required for ACNP #1359

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

abhiraut
Copy link
Contributor

@abhiraut abhiraut commented Oct 9, 2020

Update yaml to ensure appliedTo and Priority is required for ACNP as is the case with ANP. Add an e2e test to validate this
scenario.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #1359 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   64.62%   64.35%   -0.28%     
==========================================
  Files         159      159              
  Lines       12674    12674              
==========================================
- Hits         8191     8156      -35     
- Misses       3630     3661      +31     
- Partials      853      857       +4     
Flag Coverage Δ
#integration-tests 44.82% <ø> (-0.41%) ⬇️
#kind-e2e-tests 50.60% <ø> (+0.15%) ⬆️
#unit-tests 42.05% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/cniserver/server.go 68.25% <0.00%> (-10.24%) ⬇️
pkg/controller/networkpolicy/tier.go 90.00% <0.00%> (-10.00%) ⬇️
pkg/monitor/controller.go 51.47% <0.00%> (-5.89%) ⬇️
pkg/apiserver/storage/ram/watch.go 90.38% <0.00%> (-3.85%) ⬇️
...kg/controller/networkpolicy/store/networkpolicy.go 77.96% <0.00%> (-3.39%) ⬇️
pkg/apiserver/storage/ram/store.go 78.94% <0.00%> (-1.51%) ⬇️
pkg/agent/cniserver/pod_configuration.go 57.25% <0.00%> (-0.81%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 80.69% <0.00%> (ø)
...ntroller/networkpolicy/networkpolicy_controller.go 68.14% <0.00%> (+2.22%) ⬆️
pkg/apis/controlplane/v1beta1/sets.go 44.11% <0.00%> (+4.41%) ⬆️

test/e2e/antreapolicy_test.go Outdated Show resolved Hide resolved
test/e2e/antreapolicy_test.go Outdated Show resolved Hide resolved
test/e2e/antreapolicy_test.go Outdated Show resolved Hide resolved
@abhiraut
Copy link
Contributor Author

/test-all

1 similar comment
@abhiraut
Copy link
Contributor Author

/test-all

@abhiraut abhiraut requested a review from Dyanngg October 12, 2020 17:51
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhiraut abhiraut merged commit b6f7357 into antrea-io:master Oct 12, 2020
@abhiraut abhiraut deleted the req-cnp branch October 12, 2020 20:56
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Nov 10, 2020
Ensure appliedTo and priority is required for ACNP
antoninbas pushed a commit that referenced this pull request Nov 11, 2020
Ensure appliedTo and priority is required for ACNP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants