Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change: controlplane v1beta2 #1467

Merged
merged 3 commits into from
Nov 2, 2020
Merged

API change: controlplane v1beta2 #1467

merged 3 commits into from
Nov 2, 2020

Conversation

Dyanngg
Copy link
Contributor

@Dyanngg Dyanngg commented Oct 30, 2020

Merging the feature branch into master, which constitutes three PRs that involves using the new controlplane.v1beta2 API:

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@Dyanngg
Copy link
Contributor Author

Dyanngg commented Oct 30, 2020

/test-all

@codecov-io
Copy link

codecov-io commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #1467 into master will decrease coverage by 11.11%.
The diff coverage is 69.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1467       +/-   ##
===========================================
- Coverage   67.46%   56.34%   -11.12%     
===========================================
  Files         160      126       -34     
  Lines       12951    11662     -1289     
===========================================
- Hits         8737     6571     -2166     
- Misses       3285     4457     +1172     
+ Partials      929      634      -295
Flag Coverage Δ
integration-tests 45.70% <3.16%> (-1.62%) ⬇️
kind-e2e-tests ?
unit-tests 42.25% <76.26%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/openflow/client.go 46.07% <ø> (-21.79%) ⬇️
pkg/antctl/antctl.go 100.00% <ø> (ø)
pkg/antctl/command_definition.go 40.41% <0.00%> (-1.56%) ⬇️
pkg/apis/controlplane/helper.go 0.00% <ø> (ø)
pkg/apis/controlplane/sets.go 0.00% <0.00%> (-15.39%) ⬇️
pkg/apis/controlplane/v1beta1/register.go 92.85% <ø> (ø)
pkg/apis/controlplane/v1beta2/helper.go 0.00% <0.00%> (ø)
pkg/apis/controlplane/v1beta2/sets.go 0.00% <0.00%> (ø)
pkg/apis/core/v1alpha2/register.go 75.00% <ø> (ø)
pkg/apis/core/v1alpha2/webhook.go 0.00% <ø> (ø)
... and 130 more

@antoninbas
Copy link
Contributor

@Dyanngg please revert the changes to the Github workflows (addition of api-change-controlplane-v1beta2 to branches being tested) as part of this PR

@Dyanngg Dyanngg force-pushed the api-change-controlplane-v1beta2 branch from 5ac1624 to 1692fff Compare October 30, 2020 18:10
@Dyanngg
Copy link
Contributor Author

Dyanngg commented Oct 30, 2020

@Dyanngg please revert the changes to the Github workflows (addition of api-change-controlplane-v1beta2 to branches being tested) as part of this PR

Thanks for the reminder. Done

@Dyanngg
Copy link
Contributor Author

Dyanngg commented Oct 30, 2020

/test-all

antoninbas
antoninbas previously approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - It's a huge diff so I didn't review it in details, but I reviewed the individual PRs previously.

@abhiraut
Copy link
Contributor

LGTM - It's a huge diff so I didn't review it in details, but I reviewed the individual PRs previously.

LGTM - It's a huge diff so I didn't review it in details, but I reviewed the individual PRs previously.

Shall we merge Audit logging(#1216 ) first? @qiyueyao plans to push rebased version this afternoon

@Dyanngg
Copy link
Contributor Author

Dyanngg commented Oct 30, 2020

LGTM - It's a huge diff so I didn't review it in details, but I reviewed the individual PRs previously.

LGTM - It's a huge diff so I didn't review it in details, but I reviewed the individual PRs previously.

Shall we merge Audit logging(#1216 ) first? @qiyueyao plans to push rebased version this afternoon

Okay I'll wait for that

Dyanngg and others added 3 commits November 2, 2020 10:49
@Dyanngg
Upgrade ExternalEntity to v1alpha2 and controlplane API to v1beta2 (#…
1b5775f 
…1405)

* Upgrade ExternalEntity to v1alpha2 and update GroupMember struct

* Add more UT

* Add backward-comp UT testcases and address comments

* Address more comments

* Update controlplane.v1alpha1 to controlplane.v1alpha2

* Remove External Entity v1alpha1 support

* Fix yaml errors for v1alpha1 ExternalEntities

* Add upgrade tests into actions for controlplane v1beta2 branch
@Dyanngg
Deprecate GroupMemberPod (#1416)
539751d 
- Remove GroupMemberPod entirely
- Update AddressGroup and AppliedToGroup conversions
- Always add PodRef for GroupMember
@tnqn @Dyanngg
Make controlplane NetworkPolicy cluster scoped (#1445)
1f98b71 
The namespace and name of the controlplane NetworkPolicy were copied
from the namespace and name of its original NetworkPolicy. If a Antrea
NetworkPolicy and a K8s NetworkPolicy have the same namespace and name,
they would override each other when converting to controlplane
NetworkPolicy. Besides, similar to appliedToGroup and addressGroup, the
controlplane NetworkPolicy should be cluster scoped.

This patch makes the controlplane NetworkPolicy cluster scoped and
changes to use the UID of the original NetworkPolicy as its name to
ensure uniqueness.
@Dyanngg Dyanngg force-pushed the api-change-controlplane-v1beta2 branch from 1692fff to 1f98b71 Compare November 2, 2020 19:27
@Dyanngg
Copy link
Contributor Author

Dyanngg commented Nov 2, 2020

Rebased onto #1216 and resolved merge conflicts (mostly v1beta1 and v1beta2 naming conflicts). Added EnableLogging field into pkg/apis/controlplane/v1beta2/types.go.

@Dyanngg
Copy link
Contributor Author

Dyanngg commented Nov 2, 2020

/test-all

@Dyanngg Dyanngg merged commit ae45cc8 into master Nov 2, 2020
@Dyanngg Dyanngg deleted the api-change-controlplane-v1beta2 branch November 2, 2020 23:38
This was referenced Feb 1, 2021
Closed
Merged
@tnqn tnqn mentioned this pull request Apr 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

@abhiraut abhiraut abhiraut approved these changes

@tnqn tnqn Awaiting requested review from tnqn

@jianjuns jianjuns Awaiting requested review from jianjuns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Dyanngg @antrea-bot @codecov-io @antoninbas @abhiraut @vmwclabot @tnqn