Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E improvements and fixes for Antrea-native Policy #1647

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

Dyanngg
Copy link
Contributor

@Dyanngg Dyanngg commented Dec 10, 2020

This PR is based on #1396

  • Make PodSelectorMatchExp and NSSelectorMatchExp to not be pointers in np builder files
  • Unify rule and spec appliedTo struct in Antrea-native policy builders
  • Resolve a TODO item to test ANP and K8s NetworkPolicy with the same name/namespace.

@codecov-io
Copy link

codecov-io commented Dec 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@57dcaec). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1647   +/-   ##
=======================================
  Coverage        ?   62.37%           
=======================================
  Files           ?      192           
  Lines           ?    16363           
  Branches        ?        0           
=======================================
  Hits            ?    10206           
  Misses          ?     5091           
  Partials        ?     1066           
Flag Coverage Δ
e2e-tests 24.26% <0.00%> (?)
kind-e2e-tests 50.96% <0.00%> (?)
unit-tests 42.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Dyanngg Dyanngg force-pushed the np-e2e-improvements branch 2 times, most recently from 311e0a4 to 3e16e15 Compare December 21, 2020 23:27
Base automatically changed from master to main January 26, 2021 00:00
@Dyanngg Dyanngg added this to the Antrea v0.13.0 release milestone Jan 28, 2021
@Dyanngg Dyanngg requested review from abhiraut, tnqn and antoninbas and removed request for abhiraut, antoninbas and tnqn January 28, 2021 05:15
antoninbas
antoninbas previously approved these changes Jan 28, 2021
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delayed review

@Dyanngg
Copy link
Contributor Author

Dyanngg commented Jan 29, 2021

/test-all

@Dyanngg
Copy link
Contributor Author

Dyanngg commented Jan 29, 2021

@antoninbas rebased and resolved some conflicts

@Dyanngg Dyanngg merged commit c249603 into antrea-io:main Jan 29, 2021
@Dyanngg Dyanngg deleted the np-e2e-improvements branch January 29, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants