Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI cloud scripts #1651

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

antoninbas
Copy link
Contributor

Missing Docker tag after switching to projects.registry.vmware.com
registry.

Missing Docker tag after switching to projects.registry.vmware.com
registry.
@antoninbas
Copy link
Contributor Author

I started CI jobs in Jenkins for AKS/EKS/GKE to make sure this addresses the issue - I should have done that in the first place for #1617 :(

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #1651 (3cb2062) into master (9d3d10b) will decrease coverage by 1.34%.
The diff coverage is 58.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1651      +/-   ##
==========================================
- Coverage   63.31%   61.97%   -1.35%     
==========================================
  Files         170      181      +11     
  Lines       14250    15409    +1159     
==========================================
+ Hits         9023     9550     +527     
- Misses       4292     4840     +548     
- Partials      935     1019      +84     
Flag Coverage Δ
kind-e2e-tests 52.83% <53.64%> (-2.56%) ⬇️
unit-tests 40.71% <25.61%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/antrea-agent/agent.go 0.00% <0.00%> (ø)
.../agent/apiserver/handlers/networkpolicy/handler.go 58.33% <ø> (ø)
...gent/controller/noderoute/node_route_controller.go 45.83% <0.00%> (-0.64%) ⬇️
pkg/agent/stats/collector.go 97.72% <ø> (ø)
pkg/antctl/antctl.go 100.00% <ø> (ø)
pkg/antctl/transform/controllerinfo/transform.go 0.00% <ø> (ø)
pkg/antctl/transform/version/transform.go 44.82% <ø> (ø)
pkg/controller/networkpolicy/tier.go 90.00% <ø> (ø)
pkg/features/antrea_features.go 16.66% <ø> (ø)
pkg/ovs/openflow/ofctrl_builder.go 59.85% <0.00%> (-2.32%) ⬇️
... and 79 more

Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lzhecheng lzhecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas
Copy link
Contributor Author

Confirmed that all 3 cloud CI jobs are passing with this patch

@antoninbas antoninbas merged commit 7aedc36 into antrea-io:master Dec 11, 2020
@antoninbas antoninbas deleted the fix-ci-cloud-scripts branch December 11, 2020 18:13
antoninbas added a commit that referenced this pull request Dec 23, 2020
Missing Docker tag after switching to projects.registry.vmware.com
registry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants