-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow IPSec encryption only for GRE tunnel #329
Conversation
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
Although IPSec should be supported for all tunnel types according to the OVS documentation (http://docs.openvswitch.org/en/latest/howto/ipsec/), it never works for other types except GRE in all my tests. So, before we figure out the problem, I would disallow IPSec enabled for other tunnel types. |
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IPSec encryption works for only GRE tunnel, so changes Agent config validation to allow EnableIPSecTunnel only when the tunnel type is set to GRE. Also improve the logging config of strongSwan charon daemon.
/test-all |
Corrected a typo in the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IPSec encryption works for only GRE tunnel, so changes Agent config
valiation to allow EnableIPSecTunnel only when the tunnel type is
set to GRE.
Also improve the logging config of strongSwan charon daemon.